Bug 212900 (DG-Renderer-Smarty)
| Summary: | Review Request: php-pear-Structures-DataGrid-Renderer-Smarty - Renderer driver using Smarty | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-11-16 04:18:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 212898 | ||
| Bug Blocks: | 163779 | ||
|
Description
Christopher Stone
2006-10-30 01:39:27 UTC
Look like there's a typo in one of your Requires: lines:
php-pear(Strucutres_DataGrid_Renderer_Pager)
^^
Fixing this gets things going.
Another no-documentation package with an incredibly long name: W: php-pear-Structures-DataGrid-Renderer-Smarty no-documentation W: php-pear-Structures-DataGrid-Renderer-Smarty filename-too-long-for-joliet php-pear-Structures-DataGrid-Renderer-Smarty-0.1.2-1.fc7.noarch.rpm No blockers, though. * source files match upstream: a5e209d09588b82c3e46b6f4d7fef242 Structures_DataGrid_Renderer_Smarty-0.1.2.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly O rpmlint output is acceptable. * final provides and requires are sane: php-pear(Structures_DataGrid_Renderer_Smarty) = 0.1.2 php-pear-Structures-DataGrid-Renderer-Smarty = 0.1.2-1.fc7 = /bin/sh /usr/bin/pear php-Smarty php-pear(PEAR) php-pear(Structures_DataGrid_Renderer_Pager) * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear module installation). * code, not content. * no documentation, so no -docs subpackage is necessary. APPROVED Thanks for the review! :) |