Bug 212898 - (DG-Renderer-Pager) Review Request: php-pear-Structures-DataGrid-Renderer-Pager - Renderer driver using PEAR::Pager
Review Request: php-pear-Structures-DataGrid-Renderer-Pager - Renderer driver...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Package Reviews List
Depends On: php-pear-Pager pear-Structures-DG
Blocks: FE-ACCEPT DG-Renderer-Smarty
  Show dependency treegraph
Reported: 2006-10-29 20:20 EST by Christopher Stone
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-11-15 22:57:33 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wtogami: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Christopher Stone 2006-10-29 20:20:06 EST
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid-Renderer-Pager.spec

SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid-Renderer-Pager-0.1.0-1.src.rpm

This is a Renderer driver for Structures_DataGrid using PEAR::Pager.
Comment 1 Jason Tibbitts 2006-11-15 13:17:25 EST
Wow, that's a long filename.  And another no-documentation package, as well. 
What's with the PHP folks?

W: php-pear-Structures-DataGrid-Renderer-Pager no-documentation
W: php-pear-Structures-DataGrid-Renderer-Pager filename-too-long-for-joliet

I am not sure what the implications of the massive filename are.  There's
nothing in the guidelines about limiting the length of filenames so I don't
think it's a blocker, but I think the issue needs to be discussed.

Also, php-pear-Structures-DataGrid doesn't seem to be at my mirror yet even
though it was pushed 18 hours ago.  I put it in a local repository.

* source files match upstream:
  6604bb72ff0b78c8651cd17eef0d5fe4  Structures_DataGrid_Renderer_Pager-0.1.0.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
O rpmlint output is OK
* final provides and requires are sane:
   php-pear(Structures_DataGrid_Renderer_Pager) = 0.1.0
   php-pear-Structures-DataGrid-Renderer-Pager = 0.1.0-1.fc7
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module installation).
* code, not content.
* no documentation, so no -docs subpackage is necessary.

Comment 2 Christopher Stone 2006-11-15 22:57:33 EST
This package is still beta and is probably why there is no documentation yet.  I
don't think the file name length is a problem unless you are making joilet CDs
with extras packages.
Comment 3 Christopher Stone 2007-05-06 19:19:21 EDT
Package Change Request
Package Name: php-pear-Structures-DataGrid-Renderer-Pager
New Branches: EL-5

Note You need to log in before you can comment on or make changes to this bug.