Bug 212915 (pear-HTML-Table)
Summary: | Review Request: php-pear-HTML-Table - Class to easily design HTML tables | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
Component: | Package Review | Assignee: | Remi Collet <fedora> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | wtogami:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-13 07:37:43 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 212909 | ||
Bug Blocks: | 163779, 212916 |
Description
Christopher Stone
2006-10-30 03:23:22 UTC
First comment before the full review. All the tests provides succeed (pear run-tests -p HTML_Table) : Good. Version 1.7.5 is available, so please update. Should require HTML_Common >= 1.2.0 SPEC: http://tkmame.retrogames.com/fedora-extras/php-pear-HTML-Table.spec SRPM: http://tkmame.retrogames.com/fedora-extras/php-pear-HTML-Table-1.7.5-1.src.rpm %changelog * Sat Nov 11 2006 Christopher Stone <chris.stone> 1.7.5-1 - Upstream Sync - Add versioned requires == TEST ==
pear run-tests -p HTML_Table
> Running 31 tests
> 31 PASSED TESTS
== REVIEW ==
* source files match upstream:
d76f133550d326c33f7fc556afb59555 HTML_Table-1.7.5.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license (BSD)
* license is open source-compatible.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
php-pear(HTML_Table) = 1.7.5
php-pear-HTML-Table = 1.7.5-1.fc7
* %check is not present; see comment
* owns the directories it creates (HTML own by HTML_Common which is required)
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear install)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
Branch Package CVS Request ======================= Package Name: php-pear-HTML-Table Short Description: Class to easily design HTML tables Owners: chris.stone Branches: EL-5 InitialCC: |