Bug 212924 (pear-DG-Array)
| Summary: | Review Request: php-pear-Structures-DataGrid-DataSource-Array - DataSource driver using arrays | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | wtogami:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-12-02 20:58:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 212897 | ||
| Bug Blocks: | 163779 | ||
|
Description
Christopher Stone
2006-10-30 04:57:56 UTC
The by now standard rpmlint complaints: W: php-pear-Structures-DataGrid-DataSource-Array no-documentation W: php-pear-Structures-DataGrid-DataSource-Array filename-too-long-for-joliet php-pear-Structures-DataGrid-DataSource-Array-0.1.0-1.fc7.noarch.rpm There's really just a single 4K file here; not much to review, really. * source files match upstream: 9f9a76d291ee8d99134c71173bb84bdb Structures_DataGrid_DataSource_Array-0.1.0.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: php-pear(Structures_DataGrid_DataSource_Array) = 0.1.0 php-pear-Structures-DataGrid-DataSource-Array = 0.1.0-1.fc7 = /bin/sh /usr/bin/pear php-pear(PEAR) php-pear(Structures_DataGrid) * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets OK (pear module installation) * code, not content. APPROVED I must be slipping. Of course I meant O rpmlint output is OK. Thanks for the review. :) Package Change Request ====================== Package Name: php-pear-Structures-DataGrid-DaataSource-Array New Branches: EL-5 EPEL done It appears this did not get branched correctly, I noticed a typo in the name from the original request, it should be: Package Change Request ====================== Package Name: php-pear-Structures-DataGrid-DataSource-Array New Branches: EL-5 I apologize if this is what caused the problem. |