Red Hat Bugzilla – Bug 212924
Review Request: php-pear-Structures-DataGrid-DataSource-Array - DataSource driver using arrays
Last modified: 2007-11-30 17:11:47 EST
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid-DataSource-Array.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid-DataSource-Array-0.1.0-1.src.rpm Description: This is a DataSource driver for Structures_DataGrid using arrays. It is a base package for some other DataSource drivers like CSV or XML.
The by now standard rpmlint complaints: W: php-pear-Structures-DataGrid-DataSource-Array no-documentation W: php-pear-Structures-DataGrid-DataSource-Array filename-too-long-for-joliet php-pear-Structures-DataGrid-DataSource-Array-0.1.0-1.fc7.noarch.rpm There's really just a single 4K file here; not much to review, really. * source files match upstream: 9f9a76d291ee8d99134c71173bb84bdb Structures_DataGrid_DataSource_Array-0.1.0.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: php-pear(Structures_DataGrid_DataSource_Array) = 0.1.0 php-pear-Structures-DataGrid-DataSource-Array = 0.1.0-1.fc7 = /bin/sh /usr/bin/pear php-pear(PEAR) php-pear(Structures_DataGrid) * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets OK (pear module installation) * code, not content. APPROVED
I must be slipping. Of course I meant O rpmlint output is OK.
Thanks for the review. :)
Package Change Request ====================== Package Name: php-pear-Structures-DataGrid-DaataSource-Array New Branches: EL-5
EPEL done
It appears this did not get branched correctly, I noticed a typo in the name from the original request, it should be: Package Change Request ====================== Package Name: php-pear-Structures-DataGrid-DataSource-Array New Branches: EL-5 I apologize if this is what caused the problem.