Bug 2150547

Summary:	Review Request: pcem - IBM PC emulator
Product:	[Fedora] Fedora	Reporter:	Davide Cavalca <davide>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	dan, ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-12-05 17:46:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2150545, 2150546
Bug Blocks:

Description Davide Cavalca 2022-12-03 22:31:12 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/pcem/pcem.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/pcem/pcem-17-1.fc38.src.rpm

Description:
PCem (short for PC Emulator) is an IBM PC emulator that specializes in running
old operating systems and software that are designed for IBM PC compatibles.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2022-12-03 22:39:17 UTC

Note: this bundles a bunch of external projects. I'm deliberately leaving them alone for now, as upstream is in the middle of a major reorganization of the codebase and I expect they'll be a lot easier to deal with in the next release.

Comment 2 Neal Gompa 2022-12-03 23:33:45 UTC

Taking this review.

Comment 3 Neal Gompa 2022-12-03 23:35:28 UTC

Spec review:

>  -e 's:CFLAGS="-O3 -fcommon":CFLAGS="-fcommon %{optflags}":' \
>  -e 's:CXXFLAGS="-O3 -fcommon":CXXFLAGS="-fcommon %{optflags}":'

This should use %build_cflags and %build_cxxflags here.

Comment 4 Davide Cavalca 2022-12-03 23:58:11 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/pcem/pcem.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/pcem/pcem-17-1.fc38.src.rpm

Changelog:
- use %build_cflags and %build_cxxflags
- add contributed icon, .desktop and metainfo files

Comment 5 Neal Gompa 2022-12-04 00:01:35 UTC

Review notes:

* Package is named appropriately
* Licensing is correctly noted and license files are installed
* Package dependencies look sane
* No serious errors from rpmlint

PACKAGE APPROVED.

Comment 6 Gwyn Ciesla 2022-12-05 15:25:35 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/pcem

Comment 7 Fedora Update System 2022-12-05 17:44:28 UTC

FEDORA-2022-330a86234d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-330a86234d

Comment 8 Fedora Update System 2022-12-05 17:46:28 UTC

FEDORA-2022-330a86234d has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2022-12-05 19:44:51 UTC

FEDORA-2022-0b5746bee3 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0b5746bee3

Comment 10 Dan Horák 2022-12-05 22:21:06 UTC

hmm, with pcem in we could get also https://github.com/86Box/86Box in ...

Comment 11 Fedora Update System 2022-12-06 01:32:37 UTC

FEDORA-2022-0b5746bee3 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-0b5746bee3 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0b5746bee3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-12-07 01:36:02 UTC

FEDORA-2022-0b5746bee3 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.