Spec URL: https://dcavalca.fedorapeople.org/review/pcem/pcem.spec SRPM URL: https://dcavalca.fedorapeople.org/review/pcem/pcem-17-1.fc38.src.rpm Description: PCem (short for PC Emulator) is an IBM PC emulator that specializes in running old operating systems and software that are designed for IBM PC compatibles. Fedora Account System Username: dcavalca
Note: this bundles a bunch of external projects. I'm deliberately leaving them alone for now, as upstream is in the middle of a major reorganization of the codebase and I expect they'll be a lot easier to deal with in the next release.
Taking this review.
Spec review: > -e 's:CFLAGS="-O3 -fcommon":CFLAGS="-fcommon %{optflags}":' \ > -e 's:CXXFLAGS="-O3 -fcommon":CXXFLAGS="-fcommon %{optflags}":' This should use %build_cflags and %build_cxxflags here.
Spec URL: https://dcavalca.fedorapeople.org/review/pcem/pcem.spec SRPM URL: https://dcavalca.fedorapeople.org/review/pcem/pcem-17-1.fc38.src.rpm Changelog: - use %build_cflags and %build_cxxflags - add contributed icon, .desktop and metainfo files
Review notes: * Package is named appropriately * Licensing is correctly noted and license files are installed * Package dependencies look sane * No serious errors from rpmlint PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pcem
FEDORA-2022-330a86234d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-330a86234d
FEDORA-2022-330a86234d has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-0b5746bee3 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0b5746bee3
hmm, with pcem in we could get also https://github.com/86Box/86Box in ...
FEDORA-2022-0b5746bee3 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-0b5746bee3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0b5746bee3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-0b5746bee3 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.