Spec URL: https://dcavalca.fedorapeople.org/review/xtideuniversalbios/xtideuniversalbios.spec SRPM URL: https://dcavalca.fedorapeople.org/review/xtideuniversalbios/xtideuniversalbios-2.0.0^20221002svn624-1.fc38.src.rpm Description: XTIDE Universal BIOS makes it possible to use modern large ATA hard disks or Compact Flash cards on old PC's. You can then enjoy quiet or noiseless drives with more capacity than you'll ever need for old computers. XTIDE Universal BIOS (also known as simply "XUB") can be used on any IBM PC, XT, AT or 100% compatible system. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=94897231
Open to suggestions for a better filesystem location for this, I'm not sure if %{_datadir} is the right place for x86 BIOS extensions and DOS binaries.
Taking this review.
(In reply to Davide Cavalca from comment #2) > Open to suggestions for a better filesystem location for this, I'm not sure > if %{_datadir} is the right place for x86 BIOS extensions and DOS binaries. Normally, foreign platform binaries need a dedicated hierarchy, but in this case, I don't think it's not worth worrying about.
(In reply to Neal Gompa from comment #4) > (In reply to Davide Cavalca from comment #2) > > Open to suggestions for a better filesystem location for this, I'm not sure > > if %{_datadir} is the right place for x86 BIOS extensions and DOS binaries. > > Normally, foreign platform binaries need a dedicated hierarchy, but in this > case, I don't think it's not worth worrying about. Blech, I mean it's not worth worrying about.
Also, I've been poking through the source tree, and it seems like this is actually GPLv2+, rather than GPLv2...
You're right, the actual text the include is GPLv2, but a large part of the files have GPLv2+ headers. Spec URL: https://dcavalca.fedorapeople.org/review/xtideuniversalbios/xtideuniversalbios.spec SRPM URL: https://dcavalca.fedorapeople.org/review/xtideuniversalbios/xtideuniversalbios-2.0.0^20221002svn624-1.fc38.src.rpm Changelog: - update license tag
Review notes: * Package is named appropriately * Licensing is correctly noted and license files are installed * Package dependencies look sane * No serious errors from rpmlint PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/xtideuniversalbios
FEDORA-2022-3d2cd12a8d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3d2cd12a8d
FEDORA-2022-3d2cd12a8d has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-0b5746bee3 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0b5746bee3
FEDORA-2022-0b5746bee3 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-0b5746bee3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0b5746bee3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-0b5746bee3 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.