Bug 2152347

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
     Note: Multiple Release: tags found
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

fonts:
[!]: Run repo-font-audit on all fonts in package.
     Note: Cannot find repo-font-audit, install fontpackages-tools package
     to make a comprehensive font review.
     See: url: undefined
[!]: Run ttname on all fonts in package.
     Note: Cannot find ttname command, install ttname package to make a
     comprehensive font review.
     See: url: undefined


Rpmlint
-------
Checking: makemusic-finale-fonts-0-1.fc38.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp2lphw9yo')]
checks: 31, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.0 s 




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://makemusic.zendesk.com/hc/en-us/article_attachments/4402710909975/OFL.txt :
  CHECKSUM(SHA256) this package     : ddb4d751552bb20edf19e990587339e0d19206d585c8bf4acd3e6a230658d951
  CHECKSUM(SHA256) upstream package : ddb4d751552bb20edf19e990587339e0d19206d585c8bf4acd3e6a230658d951
https://makemusic.zendesk.com/hc/en-us/article_attachments/4586784089367/MMFonts.msi :
  CHECKSUM(SHA256) this package     : 8f00e2159fc1346325f1d1f98be89234a650b5d10e141831c581029cc57613d0
  CHECKSUM(SHA256) upstream package : 8f00e2159fc1346325f1d1f98be89234a650b5d10e141831c581029cc57613d0


Requires
--------


Provides
--------


Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2152347
Buildroot used: fedora-rawhide-aarch64
Active plugins: Generic, fonts, Shell-api
Disabled plugins: SugarActivity, Java, Perl, PHP, R, Python, Haskell, C/C++, Ocaml, Ruby
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

$ rpmlint makemusic-finale-fonts-0-1.fc38.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.0 s 

$ rpmlint makemusic-finale-ash-fonts-1.7-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-ash-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

$ rpmlint makemusic-finale-ash-text-fonts-1.3-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-ash-text-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

$ rpmlint makemusic-finale-broadway-fonts-1.4-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-broadway-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.3 s 

$ rpmlint makemusic-finale-broadway-legacy-text-fonts-1.1-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-broadway-legacy-text-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

$ rpmlint makemusic-finale-broadway-text-fonts-1.1-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-broadway-text-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

$ rpmlint makemusic-finale-engraver-fonts-1.4-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-engraver-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.3 s 

$ rpmlint makemusic-finale-jazz-fonts-1.9-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-jazz-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

$ rpmlint makemusic-finale-jazz-text-fonts-1.3-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-jazz-text-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

$ rpmlint makemusic-finale-jazz-text-lowercase-fonts-1.4-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-jazz-text-lowercase-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

$ rpmlint makemusic-finale-legacy-fonts-1.6-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-legacy-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

$ rpmlint makemusic-finale-lyrics-fonts-2.3-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-lyrics-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

$ rpmlint makemusic-finale-maestro-fonts-2.7-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-maestro-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.3 s 

$ rpmlint makemusic-finale-maestro-text-fonts-1.6-1.fc38.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

makemusic-finale-maestro-text-fonts.noarch: W: no-documentation
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

Comments:
a) Why use OFL-1.1-RFN rather than OFL-1.1 ?
b) Using fc-scan on the Finale Ash font file, foundry is listed as foundry: "SMTG"(s) not MakeMusic. Should this be updated?

Thanks for the review, Benson.  You're fast!  I hadn't even finished writing up an email to fedora-devel-list about this review. :-)

(In reply to Benson Muite from comment #1)
> fonts:
> [!]: Run repo-font-audit on all fonts in package.
>      Note: Cannot find repo-font-audit, install fontpackages-tools package
>      to make a comprehensive font review.
>      See: url: undefined
> [!]: Run ttname on all fonts in package.
>      Note: Cannot find ttname command, install ttname package to make a
>      comprehensive font review.
>      See: url: undefined

Wow, fedora-review is really out of date for fonts.  I see this has already been reported in bug 1996210.

> a) Why use OFL-1.1-RFN rather than OFL-1.1 ?

Several of the fonts are listed as having Reserved Font Names (RFN) in OFL.txt, which is listed as Source1.  The Lyrics font is the only one not listed there, so it is the only subpackage with license of plain OFL-1.1 instead of OFL-1.1-RFN.

> b) Using fc-scan on the Finale Ash font file, foundry is listed as foundry:
> "SMTG"(s) not MakeMusic. Should this be updated?

Hmmm.  This is what I get (in part) from "otfinfo -i" on the font files.

FinaleAsh.otf:
Manufacturer: MakeMusic
Trademark: Finale Ash is a trademark of MakeMusic.
Copyright: Copyright (c) 2021 by MakeMusic. All rights reserved.
Vendor ID: SMTG

FinaleAshText.otf:
Manufacturer: MakeMusic, Inc.
Trademark: Finale Ash Text is a trademark of MakeMusic, Inc.
Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved.
Vendor ID: MACR

FinaleBroadway.otf:
Manufacturer: MakeMusic, Inc.
Trademark: Finale Broadway is a trademark of MakeMusic, Inc..
Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved.
Vendor ID: SMTG

FinaleBroadwayLegacyText.otf:
Manufacturer: MakeMusic, Inc.
Trademark: Finale Broadway Legacy Text is a trademark of MakeMusic, Inc..
Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved.
Vendor ID: pyrs

FinaleBroadwayText.otf:
Manufacturer: Mark F. Adler
Trademark: Finale Broadway Text is a trademark of MakeMusic, Inc..
Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved.
Vendor ID: PfEd

FinaleEngraver.otf:
Manufacturer: MakeMusic, Inc.
Trademark: Finale Engraver is a trademark of MakeMusic, Inc..
Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved.
Vendor ID: SMTG

FinaleJazz.otf:
Manufacturer: MakeMusic, Inc.
Trademark: Finale Jazz is a trademark of MakeMusic, Inc..
Copyright: Copyright (c) 2022 by MakeMusic, Inc.. All rights reserved.
Vendor ID: SMTG

FinaleJazzText.otf:
Manufacturer: Richard Sigler
Trademark: Finale Jazz Text is a trademark of MakeMusic, Inc.
Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved.
Vendor ID: MACR

FinaleJazzTextLowercase.otf:
Manufacturer: Richard Sigler
Trademark: Finale Jazz Text Lowercase is a trademark of MakeMusic, Inc.
Copyright: Copyright (c) 2022 by MakeMusic, Inc. All rights reserved.
Vendor ID: MACR

FinaleLegacy.otf:
Manufacturer: MakeMusic, Inc.
Trademark: Finale Legacy is a trademark of MakeMusic, Inc..
Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved.
Vendor ID: SMTG

FinaleLyrics-Bold.otf:
Manufacturer: Mark F. Adler
Trademark: Finale Lyrics Bold is a trademark of MakeMusic, Inc..
Copyright: Copyright (c) 2021 by MakeMusic Inc.. All rights reserved.
Vendor ID: pyrs

FinaleLyrics-Italic.otf:
Manufacturer: Mark F. Adler
Trademark: Finale Lyrics Italic is a trademark of MakeMusic, Inc..
Copyright: Copyright (c) 2021 by MakeMusic Inc.. All rights reserved.
Vendor ID: pyrs

FinaleLyrics-Regular.otf:
Manufacturer: Mark F. Adler
Trademark: Finale Lyrics is a trademark of MakeMusic, Inc..
Copyright: Copyright (c) 2021 by MakeMusic Inc.. All rights reserved.
Vendor ID: pyrs

FinaleMaestro.otf:
Manufacturer: MakeMusic, Inc.
Trademark: Finale Maestro is a trademark of MakeMusic, Inc..
Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved.
Vendor ID: SMTG

FinaleMaestroText-Bold.otf:
Manufacturer: MakeMusic, Inc.
Trademark: Finale Maestro Text Bold is a trademark of MakeMusic, Inc..
Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved.
Vendor ID: pyrs

FinaleMaestroText-BoldItalic.otf:
Manufacturer: MakeMusic, Inc.
Trademark: Finale Maestro Text Bold Italic is a trademark of MakeMusic, Inc.
Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved.
Vendor ID: pyrs

FinaleMaestroText-Italic.otf:
Manufacturer: MakeMusic, Inc
Trademark: Finale Maestro Text Italic is a trademark of MakeMusic, Inc.
Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved.
Vendor ID: pyrs

FinaleMaestroText-Regular.otf:
Manufacturer: MakeMusic, Inc
Trademark: Finale Maestro Text is a trademark of MakeMusic, Inc.
Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved.
Vendor ID: pyrs

It looks like fc-scan interprets the Vendor ID as the foundry, but that doesn't look right.  Those look like some kind of internal code; they are all 4 letters for one thing.  Also, they aren't consistent, and none of them have any obvious connection with MakeMusic.  Given the trademark and copyright marks, I *think* MakeMusic is the correct foundry.

Have gotten feedback that foundry names should not be too long https://bugzilla.redhat.com/show_bug.cgi?id=2122022
From pg 58 of the spec, the VendorID is a 4 byte tag 
https://standards.iso.org/ittf/PubliclyAvailableStandards/c074461_ISO_IEC_14496-22_2019.zip

A list of Vendors and their VendorIDs is available at:
https://learn.microsoft.com/en-us/typography/vendors/
Registration seems straight forward, though with only 4 characters, space may run out as it is now much easier to generate fonts oneself.

Entries found:
MACR 	Macromedia / Made with Fontographer
PYRS 	PYRS Fontlab Ltd. / Made with FontLab

Note that PfEd is the default entry that FontForge provides, but is not registered.
SMTG - not found

Maybe the font packaging guidelines need an update?

Have an open pull request to update Fedora-review for fonts https://pagure.io/FedoraReview/pull-request/457

So the foundry name should be the same as the Vendor ID?  It sure would be nice if https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/ would say so if that is the case.  All it says is that %foundry should be:

"an optional upstream identifier, when upstream publishes multiple font families, with consistent QA rules. Font families released by the same upstream will usually play well with one another. Marking them as such helps users choose good font package sets."

Since it is optional, maybe I should omit it altogether?

In this case consistent QA rules do not seem to be followed.  

Based on the standard, the Vendor ID should link to a vendor name, but this part of the standard does not seem to be followed.

Perhaps MakeMusic would consider registering as a vendor if prompted?

The foundry/vendor name is also used in the font rpm file name. This does help in distinguishing between different types of fonts, especially ones that are modified versions of existing fonts. Maybe the guidelines should be updated to clearly indicate that "Foundry" is the rights owning entity (manufacturer/creator/foundry). The example spec file indicates:
# The identifier of the entity, that released the font family.
%global foundry           
Perhaps this should be updated to
%global vendor
or at least clearly documented as vendor.

Thus, your use of MakeMusic seems reasonable, though it would be good to check with them if they are ok with this and if they can register and fix the VendorID.

otfinfo seems useful, though in Fedora, LCDF software is bundled as https://packages.fedoraproject.org/pkgs/texlive-base/texlive-lcdftypetools/ though likely should be its own repo as it is released separately:
https://github.com/kohler/lcdf-typetools

Sorry to go silent on this for so long.  I've had to work through a number of issues with MuseScore itself.  I think I finally have them all worked out, so I'm going to try to proceed with the various font reviews needed.

For this review, I have dropped the foundry name altogether, as there doesn't seem to be a correct one to provide.  New URLs:

Spec URL: https://jjames.fedorapeople.org/makemusic-finale-fonts/makemusic-finale-fonts.spec
SRPM URL: https://jjames.fedorapeople.org/makemusic-finale-fonts/makemusic-finale-fonts-0-1.fc39.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5687579
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2152347-makemusic-finale-fonts/fedora-rawhide-x86_64/05687579-makemusic-finale-fonts/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.