Spec URL: https://jjames.fedorapeople.org/musescore/musescore.spec SRPM URL: https://jjames.fedorapeople.org/musescore/musescore-4.0.2-1.fc37.src.rpm Fedora Account System Username: jjames Description: MuseScore is a free cross platform WYSIWYG music notation program. Some highlights: * WYSIWYG, notes are entered on a "virtual note sheet" * Unlimited number of staves * Up to four voices per staff * Easy and fast note entry with mouse, keyboard or MIDI * Integrated sequencer and FluidSynth software synthesizer * Import and export of MusicXML and Standard MIDI Files (SMF) * Translated in 26 languages NOTE: the training videos do not work. Upstream uses the YouTube API to display the videos. However, their YouTube API Key is not available to downstream packagers. Therefore, the YouTube API rejects attempts to use it via MuseScore. To access the training videos, you will have to watch them in a web browser, or use the AppImage version of MuseScore. See https://copr.fedorainfracloud.org/coprs/jjames/MuseScore4/ for builds of this and related packages.
This is a rename review. The current package is named "mscore". There have been multiple requests to change the name to make it more discoverable for users.
Copr build: https://copr.fedorainfracloud.org/coprs/build/5687586 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2180243-musescore/fedora-rawhide-x86_64/05687586-musescore/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
It's going to take me a while, running fedora-review locally results in a crash and I'm checking everything myself.
Hi again, I took the template from another package and adapted it, I hope I didn't leave out anything important. There are some minor things to check and I have some questions, everything else seems in order. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. * I did my best to verify the licenses mentioned in the spec file, they seem right and kudos for sorting that mess. Besides that, rpmlint has this to say: musescore.x86_64: E: incorrect-fsf-address /usr/share/licenses/musescore/COPYING.LESSER.rtf2html musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.0/styles/cchords_muse.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.0/styles/cchords_nrb.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.0/styles/cchords_rb.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.0/styles/cchords_sym.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.0/styles/chords.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.0/styles/chords_jazz.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.0/styles/chords_std.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.0/styles/jazzchords.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.0/styles/stdchords.xml I think these should be reported and fixed upstream. [x]: Package must own all directories that it creates. * Why use both the old and new name in paths and files? [?]: Package contains no bundled libraries without FPC exception. * I see the unbundled libraries and what remains bundled, shouldn't this be in the "SHOULD" section? [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. * Some of these duplicates reported by rpmlint appear to be false positives, but not all of them: musescore.x86_64: W: files-duplicate /usr/share/mscore-4.0/locale/musescore_ar_DZ.qm /usr/share/mscore-4.0/locale/instruments_ar_DZ.qm musescore.x86_64: W: files-duplicate /usr/share/mscore-4.0/plugins/tuning_modal/modal_tuning.png /usr/share/mscore-4.0/plugins/tuning/modal_tuning.png musescore.x86_64: W: files-duplicate /usr/share/mscore-4.0/templates/05-Jazz/01-Jazz_Lead_Sheet/audiosettings.json /usr/share/mscore-4.0/templates/01-General/01-Treble_Clef/audiosettings.json:/usr/share/mscore-4.0/templates/01-General/02-Bass_Clef/audiosettings.json:/usr/share/mscore-4.0/templates/01-General/03-Grand_Staff/audiosettings.json:/usr/share/mscore-4.0/templates/02-Choral/10-Liturgical_Unmetrical/audiosettings.json:/usr/share/mscore-4.0/templates/04-Solo/01-Guitar/audiosettings.json:/usr/share/mscore-4.0/templates/04-Solo/02-Guitar_+_Tablature/audiosettings.json:/usr/share/mscore-4.0/templates/04-Solo/03-Guitar_Tablature/audiosettings.json:/usr/share/mscore-4.0/templates/04-Solo/04-Piano/audiosettings.json musescore.x86_64: W: files-duplicate /usr/share/mscore-4.0/templates/07-Band_and_Percussion/06-Battery_Percussion/score_style.mss /usr/share/mscore-4.0/templates/01-General/01-Treble_Clef/score_style.mss:/usr/share/mscore-4.0/templates/01-General/02-Bass_Clef/score_style.mss:/usr/share/mscore-4.0/templates/01-General/03-Grand_Staff/score_style.mss:/usr/share/mscore-4.0/templates/02-Choral/01-SATB/score_style.mss:/usr/share/mscore-4.0/templates/02-Choral/02-SATB_+_Organ/score_style.mss:/usr/share/mscore-4.0/templates/02-Choral/03-SATB_+_Piano/score_style.mss:/usr/share/mscore-4.0/templates/02-Choral/04-SATB_Closed_Score/score_style.mss:/usr/share/mscore-4.0/templates/02-Choral/05-SATB_Closed_Score_+_Organ/score_style.mss:/usr/share/mscore-4.0/templates/02-Choral/06-SATB_Closed_Score_+_Piano/score_style.mss:/usr/share/mscore-4.0/templates/02-Choral/07-Voice_+_Piano/score_style.mss:/usr/share/mscore-4.0/templates/02-Choral/08-Barbershop_Quartet_(Men)/score_style.mss:/usr/share/mscore-4.0/templates/02-Choral/09-Barbershop_Quartet_(Women)/score_style.mss:/usr/share/mscore-4.0/templates/04-Solo/01-Guitar/score_style.mss:/usr/share/mscore-4.0/templates/04-Solo/02-Guitar_+_Tablature/score_style.mss:/usr/share/mscore-4.0/templates/04-Solo/03-Guitar_Tablature/score_style.mss:/usr/share/mscore-4.0/templates/04-Solo/04-Piano/score_style.mss musescore.x86_64: W: files-duplicate /usr/share/mscore-4.0/templates/08-Orchestral/03-String_Orchestra/viewsettings.json /usr/share/mscore-4.0/templates/01-General/01-Treble_Clef/viewsettings.json:/usr/share/mscore-4.0/templates/01-General/02-Bass_Clef/viewsettings.json:/usr/share/mscore-4.0/templates/01-General/03-Grand_Staff/viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/01-SATB/viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/02-SATB_+_Organ/viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/03-SATB_+_Piano/viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/04-SATB_Closed_Score/viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/05-SATB_Closed_Score_+_Organ/viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/06-SATB_Closed_Score_+_Piano/viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/07-Voice_+_Piano/viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/08-Barbershop_Quartet_(Men)/viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/09-Barbershop_Quartet_(Women)/viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/10-Liturgical_Unmetrical/viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/11-Liturgical_Unmetrical_+_Organ/viewsettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/01-String_Quartet/viewsettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/02-Wind_Quartet/viewsettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/03-Wind_Quintet/viewsettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/04-Saxophone_Quartet/viewsettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/05-Brass_Quartet/viewsettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/06-Brass_Quintet/viewsettings.json:/usr/share/mscore-4.0/templates/04-Solo/01-Guitar/viewsettings.json:/usr/share/mscore-4.0/templates/04-Solo/02-Guitar_+_Tablature/viewsettings.json:/usr/share/mscore-4.0/templates/04-Solo/03-Guitar_Tablature/viewsettings.json:/usr/share/mscore-4.0/templates/04-Solo/04-Piano/viewsettings.json:/usr/share/mscore-4.0/templates/05-Jazz/01-Jazz_Lead_Sheet/viewsettings.json:/usr/share/mscore-4.0/templates/05-Jazz/02-Big_Band/viewsettings.json:/usr/share/mscore-4.0/templates/05-Jazz/03-Jazz_Combo/viewsettings.json:/usr/share/mscore-4.0/templates/06-Popular/01-Rock_Band/viewsettings.json:/usr/share/mscore-4.0/templates/06-Popular/02-Bluegrass_Band/viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/01-Concert_Band/viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/02-Small_Concert_Band/viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/03-Brass_Band/viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/04-Marching_Band/viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/05-Small_Marching_Band/viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/06-Battery_Percussion/viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/07-Large_Pit_Percussion/viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/08-Small_Pit_Percussion/viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/09-European_Concert_Band/viewsettings.json:/usr/share/mscore-4.0/templates/08-Orchestral/01-Classical_Orchestra/viewsettings.json:/usr/share/mscore-4.0/templates/08-Orchestral/02-Symphony_Orchestra/viewsettings.json musescore.x86_64: W: files-duplicate /usr/share/mscore-4.0/templates/07-Band_and_Percussion/06-Battery_Percussion/audiosettings.json /usr/share/mscore-4.0/templates/02-Choral/01-SATB/audiosettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/01-String_Quartet/audiosettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/02-Wind_Quartet/audiosettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/04-Saxophone_Quartet/audiosettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/05-Brass_Quartet/audiosettings.json musescore.x86_64: W: files-duplicate /usr/share/mscore-4.0/templates/08-Orchestral/03-String_Orchestra/audiosettings.json /usr/share/mscore-4.0/templates/02-Choral/02-SATB_+_Organ/audiosettings.json:/usr/share/mscore-4.0/templates/02-Choral/03-SATB_+_Piano/audiosettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/03-Wind_Quintet/audiosettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/06-Brass_Quintet/audiosettings.json musescore.x86_64: W: files-duplicate /usr/share/mscore-4.0/templates/02-Choral/11-Liturgical_Unmetrical_+_Organ/audiosettings.json /usr/share/mscore-4.0/templates/02-Choral/04-SATB_Closed_Score/audiosettings.json:/usr/share/mscore-4.0/templates/02-Choral/07-Voice_+_Piano/audiosettings.json:/usr/share/mscore-4.0/templates/02-Choral/08-Barbershop_Quartet_(Men)/audiosettings.json:/usr/share/mscore-4.0/templates/02-Choral/09-Barbershop_Quartet_(Women)/audiosettings.json musescore.x86_64: W: files-duplicate /usr/share/mscore-4.0/templates/02-Choral/06-SATB_Closed_Score_+_Piano/audiosettings.json /usr/share/mscore-4.0/templates/02-Choral/05-SATB_Closed_Score_+_Organ/audiosettings.json musescore.x86_64: W: files-duplicate /usr/share/mscore-4.0/templates/03-Chamber_Music/05-Brass_Quartet/score_style.mss /usr/share/mscore-4.0/templates/03-Chamber_Music/01-String_Quartet/score_style.mss:/usr/share/mscore-4.0/templates/03-Chamber_Music/02-Wind_Quartet/score_style.mss:/usr/share/mscore-4.0/templates/03-Chamber_Music/03-Wind_Quintet/score_style.mss:/usr/share/mscore-4.0/templates/03-Chamber_Music/04-Saxophone_Quartet/score_style.mss [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [-]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. * I think that "desktop-file-validate" and "appstreamcli validate" should be under %check, no? [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages.
Four months later... I'm very sorry for the huge delay. I got swamped with more urgent matters, and it has taken me this long to dig my way out of the pile and get back to this. I have updated the COPR (https://copr.fedorainfracloud.org/coprs/jjames/MuseScore4/) with new builds, and MuseScore 4.1.0. (In reply to Alexander Ploumistos from comment #4) > [x]: License field in the package spec file matches the actual license. > * I did my best to verify the licenses mentioned in the spec file, they seem > right and kudos for sorting that mess. Besides that, rpmlint has this to say: > musescore.x86_64: E: incorrect-fsf-address > /usr/share/licenses/musescore/COPYING.LESSER.rtf2html > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/cchords_muse.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/cchords_nrb.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/cchords_rb.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/cchords_sym.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/chords.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/chords_jazz.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/chords_std.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/jazzchords.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/stdchords.xml > I think these should be reported and fixed upstream. https://github.com/musescore/MuseScore/issues/18710 > [x]: Package must own all directories that it creates. > * Why use both the old and new name in paths and files? The fact that both mscore and musescore appear in upstream's distribution is probably what led to the package being named mscore in the first place. Upstream has selected the file and path names, not me. > [?]: Package contains no bundled libraries without FPC exception. > * I see the unbundled libraries and what remains bundled, shouldn't this be > in the "SHOULD" section? Yes. I believe the package complies with https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling. > [x]: Package does not contain duplicates in %files. > * Some of these duplicates reported by rpmlint appear to be false positives, > but not all of them: > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/locale/musescore_ar_DZ.qm > /usr/share/mscore-4.0/locale/instruments_ar_DZ.qm > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/plugins/tuning_modal/modal_tuning.png > /usr/share/mscore-4.0/plugins/tuning/modal_tuning.png > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/05-Jazz/01-Jazz_Lead_Sheet/audiosettings. > json > /usr/share/mscore-4.0/templates/01-General/01-Treble_Clef/audiosettings.json: > /usr/share/mscore-4.0/templates/01-General/02-Bass_Clef/audiosettings.json:/ > usr/share/mscore-4.0/templates/01-General/03-Grand_Staff/audiosettings.json:/ > usr/share/mscore-4.0/templates/02-Choral/10-Liturgical_Unmetrical/ > audiosettings.json:/usr/share/mscore-4.0/templates/04-Solo/01-Guitar/ > audiosettings.json:/usr/share/mscore-4.0/templates/04-Solo/02- > Guitar_+_Tablature/audiosettings.json:/usr/share/mscore-4.0/templates/04- > Solo/03-Guitar_Tablature/audiosettings.json:/usr/share/mscore-4.0/templates/ > 04-Solo/04-Piano/audiosettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/07-Band_and_Percussion/06-Battery_Percussion/ > score_style.mss > /usr/share/mscore-4.0/templates/01-General/01-Treble_Clef/score_style.mss:/ > usr/share/mscore-4.0/templates/01-General/02-Bass_Clef/score_style.mss:/usr/ > share/mscore-4.0/templates/01-General/03-Grand_Staff/score_style.mss:/usr/ > share/mscore-4.0/templates/02-Choral/01-SATB/score_style.mss:/usr/share/ > mscore-4.0/templates/02-Choral/02-SATB_+_Organ/score_style.mss:/usr/share/ > mscore-4.0/templates/02-Choral/03-SATB_+_Piano/score_style.mss:/usr/share/ > mscore-4.0/templates/02-Choral/04-SATB_Closed_Score/score_style.mss:/usr/ > share/mscore-4.0/templates/02-Choral/05-SATB_Closed_Score_+_Organ/ > score_style.mss:/usr/share/mscore-4.0/templates/02-Choral/06- > SATB_Closed_Score_+_Piano/score_style.mss:/usr/share/mscore-4.0/templates/02- > Choral/07-Voice_+_Piano/score_style.mss:/usr/share/mscore-4.0/templates/02- > Choral/08-Barbershop_Quartet_(Men)/score_style.mss:/usr/share/mscore-4.0/ > templates/02-Choral/09-Barbershop_Quartet_(Women)/score_style.mss:/usr/share/ > mscore-4.0/templates/04-Solo/01-Guitar/score_style.mss:/usr/share/mscore-4.0/ > templates/04-Solo/02-Guitar_+_Tablature/score_style.mss:/usr/share/mscore-4. > 0/templates/04-Solo/03-Guitar_Tablature/score_style.mss:/usr/share/mscore-4. > 0/templates/04-Solo/04-Piano/score_style.mss > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/08-Orchestral/03-String_Orchestra/ > viewsettings.json > /usr/share/mscore-4.0/templates/01-General/01-Treble_Clef/viewsettings.json:/ > usr/share/mscore-4.0/templates/01-General/02-Bass_Clef/viewsettings.json:/ > usr/share/mscore-4.0/templates/01-General/03-Grand_Staff/viewsettings.json:/ > usr/share/mscore-4.0/templates/02-Choral/01-SATB/viewsettings.json:/usr/ > share/mscore-4.0/templates/02-Choral/02-SATB_+_Organ/viewsettings.json:/usr/ > share/mscore-4.0/templates/02-Choral/03-SATB_+_Piano/viewsettings.json:/usr/ > share/mscore-4.0/templates/02-Choral/04-SATB_Closed_Score/viewsettings.json:/ > usr/share/mscore-4.0/templates/02-Choral/05-SATB_Closed_Score_+_Organ/ > viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/06- > SATB_Closed_Score_+_Piano/viewsettings.json:/usr/share/mscore-4.0/templates/ > 02-Choral/07-Voice_+_Piano/viewsettings.json:/usr/share/mscore-4.0/templates/ > 02-Choral/08-Barbershop_Quartet_(Men)/viewsettings.json:/usr/share/mscore-4. > 0/templates/02-Choral/09-Barbershop_Quartet_(Women)/viewsettings.json:/usr/ > share/mscore-4.0/templates/02-Choral/10-Liturgical_Unmetrical/viewsettings. > json:/usr/share/mscore-4.0/templates/02-Choral/11- > Liturgical_Unmetrical_+_Organ/viewsettings.json:/usr/share/mscore-4.0/ > templates/03-Chamber_Music/01-String_Quartet/viewsettings.json:/usr/share/ > mscore-4.0/templates/03-Chamber_Music/02-Wind_Quartet/viewsettings.json:/usr/ > share/mscore-4.0/templates/03-Chamber_Music/03-Wind_Quintet/viewsettings. > json:/usr/share/mscore-4.0/templates/03-Chamber_Music/04-Saxophone_Quartet/ > viewsettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/05- > Brass_Quartet/viewsettings.json:/usr/share/mscore-4.0/templates/03- > Chamber_Music/06-Brass_Quintet/viewsettings.json:/usr/share/mscore-4.0/ > templates/04-Solo/01-Guitar/viewsettings.json:/usr/share/mscore-4.0/ > templates/04-Solo/02-Guitar_+_Tablature/viewsettings.json:/usr/share/mscore- > 4.0/templates/04-Solo/03-Guitar_Tablature/viewsettings.json:/usr/share/ > mscore-4.0/templates/04-Solo/04-Piano/viewsettings.json:/usr/share/mscore-4. > 0/templates/05-Jazz/01-Jazz_Lead_Sheet/viewsettings.json:/usr/share/mscore-4. > 0/templates/05-Jazz/02-Big_Band/viewsettings.json:/usr/share/mscore-4.0/ > templates/05-Jazz/03-Jazz_Combo/viewsettings.json:/usr/share/mscore-4.0/ > templates/06-Popular/01-Rock_Band/viewsettings.json:/usr/share/mscore-4.0/ > templates/06-Popular/02-Bluegrass_Band/viewsettings.json:/usr/share/mscore-4. > 0/templates/07-Band_and_Percussion/01-Concert_Band/viewsettings.json:/usr/ > share/mscore-4.0/templates/07-Band_and_Percussion/02-Small_Concert_Band/ > viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/03- > Brass_Band/viewsettings.json:/usr/share/mscore-4.0/templates/07- > Band_and_Percussion/04-Marching_Band/viewsettings.json:/usr/share/mscore-4.0/ > templates/07-Band_and_Percussion/05-Small_Marching_Band/viewsettings.json:/ > usr/share/mscore-4.0/templates/07-Band_and_Percussion/06-Battery_Percussion/ > viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/07- > Large_Pit_Percussion/viewsettings.json:/usr/share/mscore-4.0/templates/07- > Band_and_Percussion/08-Small_Pit_Percussion/viewsettings.json:/usr/share/ > mscore-4.0/templates/07-Band_and_Percussion/09-European_Concert_Band/ > viewsettings.json:/usr/share/mscore-4.0/templates/08-Orchestral/01- > Classical_Orchestra/viewsettings.json:/usr/share/mscore-4.0/templates/08- > Orchestral/02-Symphony_Orchestra/viewsettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/07-Band_and_Percussion/06-Battery_Percussion/ > audiosettings.json > /usr/share/mscore-4.0/templates/02-Choral/01-SATB/audiosettings.json:/usr/ > share/mscore-4.0/templates/03-Chamber_Music/01-String_Quartet/audiosettings. > json:/usr/share/mscore-4.0/templates/03-Chamber_Music/02-Wind_Quartet/ > audiosettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/04- > Saxophone_Quartet/audiosettings.json:/usr/share/mscore-4.0/templates/03- > Chamber_Music/05-Brass_Quartet/audiosettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/08-Orchestral/03-String_Orchestra/ > audiosettings.json > /usr/share/mscore-4.0/templates/02-Choral/02-SATB_+_Organ/audiosettings.json: > /usr/share/mscore-4.0/templates/02-Choral/03-SATB_+_Piano/audiosettings.json: > /usr/share/mscore-4.0/templates/03-Chamber_Music/03-Wind_Quintet/ > audiosettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/06- > Brass_Quintet/audiosettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/02-Choral/11-Liturgical_Unmetrical_+_Organ/ > audiosettings.json > /usr/share/mscore-4.0/templates/02-Choral/04-SATB_Closed_Score/audiosettings. > json:/usr/share/mscore-4.0/templates/02-Choral/07-Voice_+_Piano/ > audiosettings.json:/usr/share/mscore-4.0/templates/02-Choral/08- > Barbershop_Quartet_(Men)/audiosettings.json:/usr/share/mscore-4.0/templates/ > 02-Choral/09-Barbershop_Quartet_(Women)/audiosettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/02-Choral/06-SATB_Closed_Score_+_Piano/ > audiosettings.json > /usr/share/mscore-4.0/templates/02-Choral/05-SATB_Closed_Score_+_Organ/ > audiosettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/03-Chamber_Music/05-Brass_Quartet/ > score_style.mss > /usr/share/mscore-4.0/templates/03-Chamber_Music/01-String_Quartet/ > score_style.mss:/usr/share/mscore-4.0/templates/03-Chamber_Music/02- > Wind_Quartet/score_style.mss:/usr/share/mscore-4.0/templates/03- > Chamber_Music/03-Wind_Quintet/score_style.mss:/usr/share/mscore-4.0/ > templates/03-Chamber_Music/04-Saxophone_Quartet/score_style.mss Hmmm, I'm not sure what to do about these. Those are files created and installed by upstream. I suppose I could run hardlink over the installed tree. Does RPM handle hardlinked files correctly? (And *should* these files be hardlinked? I'm not at all sure about that.) > [!]: %check is present and all tests pass. > * I think that "desktop-file-validate" and "appstreamcli validate" should be > under %check, no? https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage says that desktop-file-validate can be run in either %install or %check. Likewise, https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage says that appstream-util can be run in either %install or %check. Again, my apologies for going silent. I should have time to stay on top of this review going forward, unless Murphy decides to smite me again. New URLs: Spec URL: https://jjames.fedorapeople.org/musescore/musescore.spec SRPM URL: https://jjames.fedorapeople.org/musescore/musescore-4.1.0-1.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6187583 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2180243-musescore/fedora-rawhide-x86_64/06187583-musescore/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Jerry James from comment #5) > Hmmm, I'm not sure what to do about these. Those are files created and > installed by upstream. I suppose I could run hardlink over the installed > tree. Does RPM handle hardlinked files correctly? Yes. > (And *should* these files be hardlinked? I'm not at all sure about that.) I don’t know of anything that would *require* you to hardlink dupliate files. My personal opinion is that it is *desirable* to hardlink duplicate files when the space savings are subjectively significant, and when there is no risk of the hardlinked files residing on different filesystems. There is no risk of this when hardlinking (recursively) within a single package-owned directory. Nevertheless, rpmlint will always warn about cross-directory hardlinks even when it can be shown that the directories must be installed on the same filesystem. There is no way to avoid getting warnings about these files one way or the other.
Good information. Thanks, Ben.
The COPR has been updated to version 4.1.1. The hardlinking discussed in above is now done. New URLs: Spec URL: https://jjames.fedorapeople.org/musescore/musescore.spec SRPM URL: https://jjames.fedorapeople.org/musescore/musescore-4.1.0-1.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6218270 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2180243-musescore/srpm-builds/06218270/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Let's try that again. New URLs: Spec URL: https://jjames.fedorapeople.org/musescore/musescore.spec SRPM URL: https://jjames.fedorapeople.org/musescore/musescore-4.1.1-1.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6218308 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2180243-musescore/fedora-rawhide-x86_64/06218308-musescore/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The edwin-fonts and leland-fonts reviews are done, so we just need reviews for makemusic-finale-fonts (bug 2152347) and this one.