Spec URL: https://jjames.fedorapeople.org/makemusic-finale-fonts/makemusic-finale-fonts.spec SRPM URL: https://jjames.fedorapeople.org/makemusic-finale-fonts/makemusic-finale-fonts-0-1.fc38.src.rpm Fedora Account System Username: jjames Description: This package contains the OpenType fonts delivered with the Finale music notation system. Two of these fonts (Broadway and Maestro) will be needed by MuseScore 4.x.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. Note: Multiple Release: tags found [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. fonts: [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined [!]: Run ttname on all fonts in package. Note: Cannot find ttname command, install ttname package to make a comprehensive font review. See: url: undefined Rpmlint ------- Checking: makemusic-finale-fonts-0-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2lphw9yo')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.0 s Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://makemusic.zendesk.com/hc/en-us/article_attachments/4402710909975/OFL.txt : CHECKSUM(SHA256) this package : ddb4d751552bb20edf19e990587339e0d19206d585c8bf4acd3e6a230658d951 CHECKSUM(SHA256) upstream package : ddb4d751552bb20edf19e990587339e0d19206d585c8bf4acd3e6a230658d951 https://makemusic.zendesk.com/hc/en-us/article_attachments/4586784089367/MMFonts.msi : CHECKSUM(SHA256) this package : 8f00e2159fc1346325f1d1f98be89234a650b5d10e141831c581029cc57613d0 CHECKSUM(SHA256) upstream package : 8f00e2159fc1346325f1d1f98be89234a650b5d10e141831c581029cc57613d0 Requires -------- Provides -------- Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2152347 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, fonts, Shell-api Disabled plugins: SugarActivity, Java, Perl, PHP, R, Python, Haskell, C/C++, Ocaml, Ruby Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH $ rpmlint makemusic-finale-fonts-0-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.0 s $ rpmlint makemusic-finale-ash-fonts-1.7-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-ash-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint makemusic-finale-ash-text-fonts-1.3-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-ash-text-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint makemusic-finale-broadway-fonts-1.4-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-broadway-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.3 s $ rpmlint makemusic-finale-broadway-legacy-text-fonts-1.1-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-broadway-legacy-text-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint makemusic-finale-broadway-text-fonts-1.1-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-broadway-text-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint makemusic-finale-engraver-fonts-1.4-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-engraver-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.3 s $ rpmlint makemusic-finale-jazz-fonts-1.9-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-jazz-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint makemusic-finale-jazz-text-fonts-1.3-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-jazz-text-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint makemusic-finale-jazz-text-lowercase-fonts-1.4-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-jazz-text-lowercase-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint makemusic-finale-legacy-fonts-1.6-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-legacy-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint makemusic-finale-lyrics-fonts-2.3-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-lyrics-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint makemusic-finale-maestro-fonts-2.7-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-maestro-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.3 s $ rpmlint makemusic-finale-maestro-text-fonts-1.6-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 makemusic-finale-maestro-text-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s Comments: a) Why use OFL-1.1-RFN rather than OFL-1.1 ? b) Using fc-scan on the Finale Ash font file, foundry is listed as foundry: "SMTG"(s) not MakeMusic. Should this be updated?
Thanks for the review, Benson. You're fast! I hadn't even finished writing up an email to fedora-devel-list about this review. :-) (In reply to Benson Muite from comment #1) > fonts: > [!]: Run repo-font-audit on all fonts in package. > Note: Cannot find repo-font-audit, install fontpackages-tools package > to make a comprehensive font review. > See: url: undefined > [!]: Run ttname on all fonts in package. > Note: Cannot find ttname command, install ttname package to make a > comprehensive font review. > See: url: undefined Wow, fedora-review is really out of date for fonts. I see this has already been reported in bug 1996210. > a) Why use OFL-1.1-RFN rather than OFL-1.1 ? Several of the fonts are listed as having Reserved Font Names (RFN) in OFL.txt, which is listed as Source1. The Lyrics font is the only one not listed there, so it is the only subpackage with license of plain OFL-1.1 instead of OFL-1.1-RFN. > b) Using fc-scan on the Finale Ash font file, foundry is listed as foundry: > "SMTG"(s) not MakeMusic. Should this be updated? Hmmm. This is what I get (in part) from "otfinfo -i" on the font files. FinaleAsh.otf: Manufacturer: MakeMusic Trademark: Finale Ash is a trademark of MakeMusic. Copyright: Copyright (c) 2021 by MakeMusic. All rights reserved. Vendor ID: SMTG FinaleAshText.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Ash Text is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved. Vendor ID: MACR FinaleBroadway.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Broadway is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: SMTG FinaleBroadwayLegacyText.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Broadway Legacy Text is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: pyrs FinaleBroadwayText.otf: Manufacturer: Mark F. Adler Trademark: Finale Broadway Text is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: PfEd FinaleEngraver.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Engraver is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: SMTG FinaleJazz.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Jazz is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2022 by MakeMusic, Inc.. All rights reserved. Vendor ID: SMTG FinaleJazzText.otf: Manufacturer: Richard Sigler Trademark: Finale Jazz Text is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved. Vendor ID: MACR FinaleJazzTextLowercase.otf: Manufacturer: Richard Sigler Trademark: Finale Jazz Text Lowercase is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2022 by MakeMusic, Inc. All rights reserved. Vendor ID: MACR FinaleLegacy.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Legacy is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: SMTG FinaleLyrics-Bold.otf: Manufacturer: Mark F. Adler Trademark: Finale Lyrics Bold is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic Inc.. All rights reserved. Vendor ID: pyrs FinaleLyrics-Italic.otf: Manufacturer: Mark F. Adler Trademark: Finale Lyrics Italic is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic Inc.. All rights reserved. Vendor ID: pyrs FinaleLyrics-Regular.otf: Manufacturer: Mark F. Adler Trademark: Finale Lyrics is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic Inc.. All rights reserved. Vendor ID: pyrs FinaleMaestro.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Maestro is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: SMTG FinaleMaestroText-Bold.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Maestro Text Bold is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: pyrs FinaleMaestroText-BoldItalic.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Maestro Text Bold Italic is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved. Vendor ID: pyrs FinaleMaestroText-Italic.otf: Manufacturer: MakeMusic, Inc Trademark: Finale Maestro Text Italic is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved. Vendor ID: pyrs FinaleMaestroText-Regular.otf: Manufacturer: MakeMusic, Inc Trademark: Finale Maestro Text is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved. Vendor ID: pyrs It looks like fc-scan interprets the Vendor ID as the foundry, but that doesn't look right. Those look like some kind of internal code; they are all 4 letters for one thing. Also, they aren't consistent, and none of them have any obvious connection with MakeMusic. Given the trademark and copyright marks, I *think* MakeMusic is the correct foundry.
Have gotten feedback that foundry names should not be too long https://bugzilla.redhat.com/show_bug.cgi?id=2122022 From pg 58 of the spec, the VendorID is a 4 byte tag https://standards.iso.org/ittf/PubliclyAvailableStandards/c074461_ISO_IEC_14496-22_2019.zip A list of Vendors and their VendorIDs is available at: https://learn.microsoft.com/en-us/typography/vendors/ Registration seems straight forward, though with only 4 characters, space may run out as it is now much easier to generate fonts oneself. Entries found: MACR Macromedia / Made with Fontographer PYRS PYRS Fontlab Ltd. / Made with FontLab Note that PfEd is the default entry that FontForge provides, but is not registered. SMTG - not found Maybe the font packaging guidelines need an update? Have an open pull request to update Fedora-review for fonts https://pagure.io/FedoraReview/pull-request/457
So the foundry name should be the same as the Vendor ID? It sure would be nice if https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/ would say so if that is the case. All it says is that %foundry should be: "an optional upstream identifier, when upstream publishes multiple font families, with consistent QA rules. Font families released by the same upstream will usually play well with one another. Marking them as such helps users choose good font package sets." Since it is optional, maybe I should omit it altogether?
In this case consistent QA rules do not seem to be followed. Based on the standard, the Vendor ID should link to a vendor name, but this part of the standard does not seem to be followed. Perhaps MakeMusic would consider registering as a vendor if prompted? The foundry/vendor name is also used in the font rpm file name. This does help in distinguishing between different types of fonts, especially ones that are modified versions of existing fonts. Maybe the guidelines should be updated to clearly indicate that "Foundry" is the rights owning entity (manufacturer/creator/foundry). The example spec file indicates: # The identifier of the entity, that released the font family. %global foundry Perhaps this should be updated to %global vendor or at least clearly documented as vendor. Thus, your use of MakeMusic seems reasonable, though it would be good to check with them if they are ok with this and if they can register and fix the VendorID. otfinfo seems useful, though in Fedora, LCDF software is bundled as https://packages.fedoraproject.org/pkgs/texlive-base/texlive-lcdftypetools/ though likely should be its own repo as it is released separately: https://github.com/kohler/lcdf-typetools
Sorry to go silent on this for so long. I've had to work through a number of issues with MuseScore itself. I think I finally have them all worked out, so I'm going to try to proceed with the various font reviews needed. For this review, I have dropped the foundry name altogether, as there doesn't seem to be a correct one to provide. New URLs: Spec URL: https://jjames.fedorapeople.org/makemusic-finale-fonts/makemusic-finale-fonts.spec SRPM URL: https://jjames.fedorapeople.org/makemusic-finale-fonts/makemusic-finale-fonts-0-1.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/5687579 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2152347-makemusic-finale-fonts/fedora-rawhide-x86_64/05687579-makemusic-finale-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [!]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/SMuFL [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/SMuFL/Fonts, /usr/share/SMuFL [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). fonts: [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined [!]: Run ttname on all fonts in package. Note: Cannot find ttname command, install ttname package to make a comprehensive font review. See: url: undefined Rpmlint ------- Checking: finale-ash-fonts-1.7-1.fc39.noarch.rpm finale-ash-text-fonts-1.3-1.fc39.noarch.rpm finale-broadway-fonts-1.4-1.fc39.noarch.rpm finale-broadway-legacy-text-fonts-1.1-1.fc39.noarch.rpm finale-broadway-text-fonts-1.1-1.fc39.noarch.rpm finale-engraver-fonts-1.4-1.fc39.noarch.rpm finale-jazz-fonts-1.9-1.fc39.noarch.rpm finale-jazz-text-fonts-1.3-1.fc39.noarch.rpm finale-jazz-text-lowercase-fonts-1.4-1.fc39.noarch.rpm finale-legacy-fonts-1.6-1.fc39.noarch.rpm finale-lyrics-fonts-2.3-1.fc39.noarch.rpm finale-maestro-fonts-2.7-1.fc39.noarch.rpm finale-maestro-text-fonts-1.6-1.fc39.noarch.rpm makemusic-finale-fonts-0-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp10chakth')] checks: 31, packages: 14 finale-ash-fonts.noarch: W: no-documentation finale-ash-text-fonts.noarch: W: no-documentation finale-broadway-fonts.noarch: W: no-documentation finale-broadway-legacy-text-fonts.noarch: W: no-documentation finale-broadway-text-fonts.noarch: W: no-documentation finale-engraver-fonts.noarch: W: no-documentation finale-jazz-fonts.noarch: W: no-documentation finale-jazz-text-fonts.noarch: W: no-documentation finale-jazz-text-lowercase-fonts.noarch: W: no-documentation finale-legacy-fonts.noarch: W: no-documentation finale-lyrics-fonts.noarch: W: no-documentation finale-maestro-fonts.noarch: W: no-documentation finale-maestro-text-fonts.noarch: W: no-documentation 14 packages and 0 specfiles checked; 0 errors, 13 warnings, 0 badness; has taken 3.6 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 13 finale-maestro-fonts.noarch: W: no-documentation finale-jazz-text-lowercase-fonts.noarch: W: no-documentation finale-broadway-legacy-text-fonts.noarch: W: no-documentation finale-jazz-text-fonts.noarch: W: no-documentation finale-lyrics-fonts.noarch: W: no-documentation finale-ash-text-fonts.noarch: W: no-documentation finale-broadway-fonts.noarch: W: no-documentation finale-maestro-text-fonts.noarch: W: no-documentation finale-legacy-fonts.noarch: W: no-documentation finale-engraver-fonts.noarch: W: no-documentation finale-ash-fonts.noarch: W: no-documentation finale-jazz-fonts.noarch: W: no-documentation finale-broadway-text-fonts.noarch: W: no-documentation 13 packages and 0 specfiles checked; 0 errors, 13 warnings, 0 badness; has taken 0.8 s Source checksums ---------------- https://makemusic.zendesk.com/hc/en-us/article_attachments/4402710909975/OFL.txt : CHECKSUM(SHA256) this package : ddb4d751552bb20edf19e990587339e0d19206d585c8bf4acd3e6a230658d951 CHECKSUM(SHA256) upstream package : ddb4d751552bb20edf19e990587339e0d19206d585c8bf4acd3e6a230658d951 https://makemusic.zendesk.com/hc/en-us/article_attachments/4586784089367/MMFonts.msi : CHECKSUM(SHA256) this package : 8f00e2159fc1346325f1d1f98be89234a650b5d10e141831c581029cc57613d0 CHECKSUM(SHA256) upstream package : 8f00e2159fc1346325f1d1f98be89234a650b5d10e141831c581029cc57613d0 Requires -------- finale-ash-fonts (rpmlib, GLIBC filtered): config(finale-ash-fonts) fontpackages-filesystem finale-ash-text-fonts (rpmlib, GLIBC filtered): config(finale-ash-text-fonts) fontpackages-filesystem finale-broadway-fonts (rpmlib, GLIBC filtered): config(finale-broadway-fonts) fontpackages-filesystem finale-broadway-legacy-text-fonts (rpmlib, GLIBC filtered): config(finale-broadway-legacy-text-fonts) fontpackages-filesystem finale-broadway-text-fonts (rpmlib, GLIBC filtered): config(finale-broadway-text-fonts) fontpackages-filesystem finale-engraver-fonts (rpmlib, GLIBC filtered): config(finale-engraver-fonts) fontpackages-filesystem finale-jazz-fonts (rpmlib, GLIBC filtered): config(finale-jazz-fonts) fontpackages-filesystem finale-jazz-text-fonts (rpmlib, GLIBC filtered): config(finale-jazz-text-fonts) fontpackages-filesystem finale-jazz-text-lowercase-fonts (rpmlib, GLIBC filtered): config(finale-jazz-text-lowercase-fonts) fontpackages-filesystem finale-legacy-fonts (rpmlib, GLIBC filtered): config(finale-legacy-fonts) fontpackages-filesystem finale-lyrics-fonts (rpmlib, GLIBC filtered): config(finale-lyrics-fonts) fontpackages-filesystem finale-maestro-fonts (rpmlib, GLIBC filtered): config(finale-maestro-fonts) fontpackages-filesystem finale-maestro-text-fonts (rpmlib, GLIBC filtered): config(finale-maestro-text-fonts) fontpackages-filesystem Provides -------- finale-ash-fonts: config(finale-ash-fonts) finale-ash-fonts font(finaleash) metainfo() metainfo(com.makemusic.finale-ash-fonts.metainfo.xml) finale-ash-text-fonts: config(finale-ash-text-fonts) finale-ash-text-fonts font(finaleashtext) metainfo() metainfo(com.makemusic.finale-ash-text-fonts.metainfo.xml) finale-broadway-fonts: config(finale-broadway-fonts) finale-broadway-fonts font(finalebroadway) metainfo() metainfo(com.makemusic.finale-broadway-fonts.metainfo.xml) finale-broadway-legacy-text-fonts: config(finale-broadway-legacy-text-fonts) finale-broadway-legacy-text-fonts font(finalebroadwaylegacytext) metainfo() metainfo(com.makemusic.finale-broadway-legacy-text-fonts.metainfo.xml) finale-broadway-text-fonts: config(finale-broadway-text-fonts) finale-broadway-text-fonts font(finalebroadwaytext) metainfo() metainfo(com.makemusic.finale-broadway-text-fonts.metainfo.xml) finale-engraver-fonts: config(finale-engraver-fonts) finale-engraver-fonts font(finaleengraver) metainfo() metainfo(com.makemusic.finale-engraver-fonts.metainfo.xml) finale-jazz-fonts: config(finale-jazz-fonts) finale-jazz-fonts font(finalejazz) metainfo() metainfo(com.makemusic.finale-jazz-fonts.metainfo.xml) finale-jazz-text-fonts: config(finale-jazz-text-fonts) finale-jazz-text-fonts font(finalejazztext) metainfo() metainfo(com.makemusic.finale-jazz-text-fonts.metainfo.xml) finale-jazz-text-lowercase-fonts: config(finale-jazz-text-lowercase-fonts) finale-jazz-text-lowercase-fonts font(finalejazztextlowercase) metainfo() metainfo(com.makemusic.finale-jazz-text-lowercase-fonts.metainfo.xml) finale-legacy-fonts: config(finale-legacy-fonts) finale-legacy-fonts font(finalelegacy) metainfo() metainfo(com.makemusic.finale-legacy-fonts.metainfo.xml) finale-lyrics-fonts: config(finale-lyrics-fonts) finale-lyrics-fonts font(finalelyrics) metainfo() metainfo(com.makemusic.finale-lyrics-fonts.metainfo.xml) finale-maestro-fonts: config(finale-maestro-fonts) finale-maestro-fonts font(finalemaestro) metainfo() metainfo(com.makemusic.finale-maestro-fonts.metainfo.xml) finale-maestro-text-fonts: config(finale-maestro-text-fonts) finale-maestro-text-fonts font(finalemaestrotext) metainfo() metainfo(com.makemusic.finale-maestro-text-fonts.metainfo.xml) Diff spec file in url and in SRPM --------------------------------- --- /home/benson/Projects/FedoraPackaging/reviews/makemusic-finale-fonts/2152347-makemusic-finale-fonts/srpm/makemusic-finale-fonts.spec 2023-06-19 15:22:23.395593242 +0300 +++ /home/benson/Projects/FedoraPackaging/reviews/makemusic-finale-fonts/2152347-makemusic-finale-fonts/srpm-unpacked/makemusic-finale-fonts.spec 2023-03-16 03:00:00.000000000 +0300 @@ -252,6 +252,8 @@ %setup -q -c -T msiextract %{SOURCE0} -cp -p %{SOURCE1} . -%linuxtext -n OFL.txt + +# Fix end of line encodings +sed 's/\r//' %{SOURCE1} > OFL.txt +touch -r %{SOURCE1} OFL.txt %build Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2152347 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, fonts Disabled plugins: Haskell, C/C++, Java, PHP, Perl, Ruby, R, Python, SugarActivity, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Due to packaging as MSI timestamps cannot be preserved b) Is it possible to add below or equivalent to the spec file to ensure directory ownership %dir %{_datadir}/SMuFL %dir %{_datadir}/SMuFL/Fonts %dir %{_datadir}/SMuFL/Fonts/'Finale Ash' %dir %{_datadir}/SMuFL/Fonts/'Finale Ash Text' %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway' %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway Text' %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway Legacy Text' %dir %{_datadir}/SMuFL/Fonts/'Finale Engraver' %dir %{_datadir}/SMuFL/Fonts/'Finale Jazz Text' %dir %{_datadir}/SMuFL/Fonts/'Finale Jazz Text Lowercase' %dir %{_datadir}/SMuFL/Fonts/'Finale Legacy' %dir %{_datadir}/SMuFL/Fonts/'Finale Ash' %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro' %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text' %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Bold' %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Bold Italic' %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Italic' c) Should there be a license declaration %global fontlicenses OFL.txt Font license is not installed with any of the font files d) The msi package includes some additional TTF fonts. Assume these are not needed?
Thank you, Benson. (In reply to Benson Muite from comment #9) > b) Is it possible to add below or equivalent to the spec file to ensure > directory ownership > %dir %{_datadir}/SMuFL > %dir %{_datadir}/SMuFL/Fonts > %dir %{_datadir}/SMuFL/Fonts/'Finale Ash' > %dir %{_datadir}/SMuFL/Fonts/'Finale Ash Text' > %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway' > %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway Text' > %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway Legacy Text' > %dir %{_datadir}/SMuFL/Fonts/'Finale Engraver' > %dir %{_datadir}/SMuFL/Fonts/'Finale Jazz Text' > %dir %{_datadir}/SMuFL/Fonts/'Finale Jazz Text Lowercase' > %dir %{_datadir}/SMuFL/Fonts/'Finale Legacy' > %dir %{_datadir}/SMuFL/Fonts/'Finale Ash' > %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro' > %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text' > %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Bold' > %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Bold Italic' > %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Italic' Oops, yes, those were supposed to be in there. I have added the first two to each subpackage. The rest are not needed as the same path without %dir is already present. > c) Should there be a license declaration > %global fontlicenses OFL.txt > Font license is not installed with any of the font files Yes, I forgot the -l argument to %fontinstall. It's a good thing you are reviewing this package to catch my mistakes. :-) > d) The msi package includes some additional TTF fonts. Assume these are not > needed? Yes, I think those are all either "legacy" fonts that are no longer supported, or duplicates of the OpenType fonts in these packages. In any case, MuseScore doesn't need any of them. New URLs: Spec URL: https://jjames.fedorapeople.org/makemusic-finale-fonts/makemusic-finale-fonts.spec SRPM URL: https://jjames.fedorapeople.org/makemusic-finale-fonts/makemusic-finale-fonts-0-1.fc40.src.rpm
Created attachment 1984670 [details] The .spec file difference from Copr build 5687579 to 6335340
Copr build: https://copr.fedorainfracloud.org/coprs/build/6335340 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2152347-makemusic-finale-fonts/fedora-rawhide-x86_64/06335340-makemusic-finale-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks. Seems ok. Currently Finale Maestro and Finale Broadway are included in the main repository https://github.com/musescore/MuseScore/tree/master/fonts though the main download location for these is at https://makemusic.zendesk.com/hc/en-us/articles/1500013053461-MakeMusic-Fonts-and-Licensing-Information - maybe MuseScore should update them for their own use? You might also consider changing the foundry id to be SMTG consistently and perhaps ask MakeMusic to update this information. See for example: https://src.fedoraproject.org/rpms/lomt-junction-fonts/blob/rawhide/f/update-foundry.pe But not essential. Approved.
Thanks again, Benson. (In reply to Benson Muite from comment #13) > Thanks. Seems ok. Currently Finale Maestro and Finale Broadway are included > in the main repository > https://github.com/musescore/MuseScore/tree/master/fonts though the main > download location for these is at > https://makemusic.zendesk.com/hc/en-us/articles/1500013053461-MakeMusic- > Fonts-and-Licensing-Information - maybe MuseScore should update them for > their own use? You might also consider changing the foundry id to be SMTG > consistently and perhaps ask MakeMusic to update this information. See for > example: > https://src.fedoraproject.org/rpms/lomt-junction-fonts/blob/rawhide/f/update- > foundry.pe > > But not essential. > > Approved. I'm hesitating because I still don't know what SMTG refers to, nor is it a registered foundry name. The other fonts have vendor IDs that refer to the program used to make the font: MACR, pyrs, and PfEd. I wonder if SMTG is yet another font editing software suite. I will try to contact somebody upstream to ask about that.
The Pagure repository was created at https://src.fedoraproject.org/rpms/makemusic-finale-fonts
FEDORA-2023-2ffff9b578 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2ffff9b578
FEDORA-2023-2ffff9b578 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-2ffff9b578 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-2ffff9b578 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-2ffff9b578 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.