Bug 2161337

Summary:	Review Request: python-types-python-dateutil - Typing stubs for dateutil
Product:	[Fedora] Fedora	Reporter:	Ankur Sinha (FranciscoD) <sanjay.ankur>
Component:	Package Review	Assignee:	Neil Hanlon <neil>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	code, neil, package-review, ppisar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	Trivial
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-02-28 11:26:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1276941

Description Ankur Sinha (FranciscoD) 2023-01-16 16:22:03 UTC

Spec URL: https://ankursinha.fedorapeople.org/python-types-python-dateutil/python-types-python-dateutil.spec
SRPM URL: https://ankursinha.fedorapeople.org/python-types-python-dateutil/python-types-python-dateutil-2.8.19.5-2.fc38.src.rpm

Description:
This is a PEP 561 type stub package for the python-dateutil package. It can be
used by type-checking tools like mypy, PyCharm, pytype etc. to check code that
uses python-dateutil. The source for this package can be found at
https://github.com/python/typeshed/tree/main/stubs/python-dateutil. All fixes
for types and metadata should be contributed there.

See https://github.com/python/typeshed/blob/main/README.md for more details.
This package was generated from typeshed commit
bff43b53e50adf873c20faebb125a5fe808d4ad6.

Fedora Account System Username: ankursinha

Comment 1 Ankur Sinha (FranciscoD) 2023-01-16 16:22:06 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=96210656

Comment 2 Jakub Kadlčík 2023-01-16 16:28:01 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5238133
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161337-python-types-python-dateutil/fedora-rawhide-x86_64/05238133-python-types-python-dateutil/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 3 Ben Beasley 2023-01-16 17:37:21 UTC

Is this a runtime dependency or a BuildRequires for testing? If it’s the latter, you might be better patching out the typechecker from the tests (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters).

Comment 4 Ankur Sinha (FranciscoD) 2023-01-16 18:06:19 UTC

Ah, right. This one is BR for testing datalad locally. I'll take a look at patching it out first.

Comment 5 Ben Beasley 2023-01-16 18:14:30 UTC

I’m happy to review it if it’s not just for mypy. There are a few Python libraries that use type information at runtime, although I bet this isn’t one of those cases.

Comment 6 Neil Hanlon 2023-01-28 20:58:51 UTC

oops. I apologize, i didn't read the whole discussion before taking. Still happy to take this as my first review if it is necessary.

Comment 7 Ankur Sinha (FranciscoD) 2023-02-28 11:26:20 UTC

Sorry for the delay folks. This is indeed only a linting dep, so we won't package it.

Neil, sorry about that. I have a couple of other reviews pending if you'd like to take them up:

https://bugzilla.redhat.com/show_bug.cgi?id=2173665
https://bugzilla.redhat.com/show_bug.cgi?id=2166009

Comment 8 Neil Hanlon 2023-03-01 00:58:33 UTC

(In reply to Ankur Sinha (FranciscoD) from comment #7)
> Sorry for the delay folks. This is indeed only a linting dep, so we won't
> package it.
> 
> Neil, sorry about that. I have a couple of other reviews pending if you'd
> like to take them up:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=2173665
> https://bugzilla.redhat.com/show_bug.cgi?id=2166009

Not a problem. I will take a look and see if I might be able to take one of them on with my current workload.

Thank you!