Spec URL: https://ankursinha.fedorapeople.org/python-types-python-dateutil/python-types-python-dateutil.spec SRPM URL: https://ankursinha.fedorapeople.org/python-types-python-dateutil/python-types-python-dateutil-2.8.19.5-2.fc38.src.rpm Description: This is a PEP 561 type stub package for the python-dateutil package. It can be used by type-checking tools like mypy, PyCharm, pytype etc. to check code that uses python-dateutil. The source for this package can be found at https://github.com/python/typeshed/tree/main/stubs/python-dateutil. All fixes for types and metadata should be contributed there. See https://github.com/python/typeshed/blob/main/README.md for more details. This package was generated from typeshed commit bff43b53e50adf873c20faebb125a5fe808d4ad6. Fedora Account System Username: ankursinha
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=96210656
Copr build: https://copr.fedorainfracloud.org/coprs/build/5238133 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161337-python-types-python-dateutil/fedora-rawhide-x86_64/05238133-python-types-python-dateutil/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Is this a runtime dependency or a BuildRequires for testing? If it’s the latter, you might be better patching out the typechecker from the tests (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters).
Ah, right. This one is BR for testing datalad locally. I'll take a look at patching it out first.
I’m happy to review it if it’s not just for mypy. There are a few Python libraries that use type information at runtime, although I bet this isn’t one of those cases.
oops. I apologize, i didn't read the whole discussion before taking. Still happy to take this as my first review if it is necessary.
Sorry for the delay folks. This is indeed only a linting dep, so we won't package it. Neil, sorry about that. I have a couple of other reviews pending if you'd like to take them up: https://bugzilla.redhat.com/show_bug.cgi?id=2173665 https://bugzilla.redhat.com/show_bug.cgi?id=2166009
(In reply to Ankur Sinha (FranciscoD) from comment #7) > Sorry for the delay folks. This is indeed only a linting dep, so we won't > package it. > > Neil, sorry about that. I have a couple of other reviews pending if you'd > like to take them up: > > https://bugzilla.redhat.com/show_bug.cgi?id=2173665 > https://bugzilla.redhat.com/show_bug.cgi?id=2166009 Not a problem. I will take a look and see if I might be able to take one of them on with my current workload. Thank you!