Bug 2176017

Summary: future fails to build with Python 3.12: SyntaxError: source code string cannot contain null bytes
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: futureAssignee: Antonio T. sagitter <trpost>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: mhroncok, thrnciar, trpost
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: future-0.18.3-5.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-18 17:28:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2135404    

Description Tomáš Hrnčiar 2023-03-07 07:43:10 UTC
future fails to build with Python 3.12.0a5.

___________________________ BuiltinTest.test_compile ___________________________

self = <test_future.test_builtins.BuiltinTest testMethod=test_compile>

    def test_compile(self):
        compile('print(1)\n', '', 'exec')
        bom = b'\xef\xbb\xbf'
        compile(bom + b'print(1)\n', '', 'exec')
        compile(source='pass', filename='?', mode='exec')
        compile(dont_inherit=0, filename='tmp', source='0', mode='eval')
        compile('pass', '?', dont_inherit=1, mode='exec')
        # Fails on Py2.7:
        # Was: compile(memoryview(b"text"), "name", "exec")
        self.assertRaises(TypeError, compile)
        self.assertRaises(ValueError, compile, 'print(42)\n', '<string>', 'badmode')
        self.assertRaises(ValueError, compile, 'print(42)\n', '<string>', 'single', 0xff)
        # Raises TypeError in Python < v3.5, ValueError in v3.5:
>       self.assertRaises((TypeError, ValueError), compile, chr(0), 'f', 'exec')
E       SyntaxError: source code string cannot contain null bytes

tests/test_future/test_builtins.py:527: SyntaxError

The parser now raises SyntaxError when parsing source code containing null bytes. (Contributed by Pablo Galindo in gh-96670.)

https://github.com/python/cpython/issues/96670
https://docs.python.org/3.12/whatsnew/3.12.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.12/fedora-rawhide-x86_64/05598396-future/

For all our attempts to build future with Python 3.12, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/package/future/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.12:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/

Let us know here if you have any questions.

Python 3.12 is planned to be included in Fedora 39. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.12.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Tomáš Hrnčiar 2023-05-16 10:58:47 UTC
I've reported this upstream https://github.com/PythonCharmers/python-future/issues/618.
Setting severity to high since this is currently the biggest blocker for Python 3.12 mass rebuild, blocking ~80 packages.

Comment 2 Tomáš Hrnčiar 2023-05-17 13:14:32 UTC
PR: https://src.fedoraproject.org/rpms/future/pull-request/11

Comment 3 Fedora Update System 2023-05-18 17:26:49 UTC
FEDORA-2023-7632e5494d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7632e5494d

Comment 4 Fedora Update System 2023-05-18 17:28:31 UTC
FEDORA-2023-7632e5494d has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.