Bug 217671

Summary: Review Request: libhangul - Hangul input library
Product: [Fedora] Fedora Reporter: Akira TAGOH <tagoh>
Component: Package ReviewAssignee: Jens Petersen <petersen>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dcantrell, eng-i18n-bugs, fedora-package-review, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-03-22 08:56:50 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 188268    
Attachments:
Description Flags
libhangul.spec-1.patch
none
libhangul.spec-2.patch none

Description Akira TAGOH 2006-11-29 05:15:21 EST
Spec URL: http://people.redhat.com/tagoh/libhangul/libhangul.spec
SRPM URL: http://people.redhat.com/tagoh/libhangul/libhangul-0.0.3-1.src.rpm
Description:
libhangul provides common features to develop applications that needs Hangul 
input facilities.


This library is required to build scim-hangul.
Comment 1 Jens Petersen 2007-01-07 20:18:39 EST
libhangul-0.0.4 was released btw.

Comment 2 Jens Petersen 2007-01-07 20:23:57 EST
Created attachment 145019 [details]
libhangul.spec-1.patch

Fix:
- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
- MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}

and for the include dir:

- MUST: A package must own all directories that it creates.

All the other MUST items are satisfied, thanks.
Comment 3 Jens Petersen 2007-02-15 23:36:17 EST
s/Fix/Fixes/
Comment 4 Akira TAGOH 2007-02-16 08:04:46 EST
Thanks for reviewing. updated spec file and srpm file are:

Spec URL: http://people.redhat.com/tagoh/libhangul/libhangul.spec
SRPM URL: http://people.redhat.com/tagoh/libhangul/libhangul-0.0.4-1.src.rpm
Comment 5 Jens Petersen 2007-02-18 21:46:04 EST
Here is the review:

= rpmlint gives:
W: libhangul-devel no-documentation
but I think this is probably ok
+ package naming is good
+ spec filename matches package name
+ meets packaging guidelines
+ license is LGPL
+ license in spec file is correct
+ COPYING file is included in %doc files
- I attach a small patch to improve the English descriptions
+ spec file is legible
+ md5sum matches upstream tarball
a32301e03a381917cb2ec836a43a9664  libhangul-0.0.4.tar.gz
+ builds on fc6 i386
+ no build dependencies
+ no translations
+ has correct ldconfig scripts
+ owns all its directories
+ no duplicate files in filelists
+ has %defattr lines
+ has %clean
+ macro use is consistent
+ no large documentation
+ %doc files do not affect runtime
+ has devel subpackage
+ devel requires pkgconfig
+ lib*.so is in -devel
+ devel package requires main package with full nvr
+ removes .la file
+ only owns its own dirs
Comment 6 Jens Petersen 2007-02-18 21:57:32 EST
Created attachment 148309 [details]
libhangul.spec-2.patch

Small patch to improve the descriptions.
Sorry I should have included this in the first patch.
Comment 8 Jens Petersen 2007-02-19 00:23:39 EST
Thanks, srpm looks good now.

Package is APPROVED.

Comment 9 Jesse Keating 2007-03-22 07:49:53 EDT
Eeek, kind of late with the feature freeze already in effect, but I'll wave that
for this (and I presume scim-hangul).

I've added it to the build system.  Please let me know when you've built it so I
can tag it for Test3.
Comment 10 Akira TAGOH 2007-03-22 08:56:50 EDT
Thanks for adding. yes, this is for scim-hangul.

I've built libhangul-0.0.4-2.fc7 and scim-hangul-0.3.1-1.fc7 into brew now.