Spec URL: http://people.redhat.com/tagoh/libhangul/libhangul.spec SRPM URL: http://people.redhat.com/tagoh/libhangul/libhangul-0.0.3-1.src.rpm Description: libhangul provides common features to develop applications that needs Hangul input facilities. This library is required to build scim-hangul.
libhangul-0.0.4 was released btw.
Created attachment 145019 [details] libhangul.spec-1.patch Fix: - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). - MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} and for the include dir: - MUST: A package must own all directories that it creates. All the other MUST items are satisfied, thanks.
s/Fix/Fixes/
Thanks for reviewing. updated spec file and srpm file are: Spec URL: http://people.redhat.com/tagoh/libhangul/libhangul.spec SRPM URL: http://people.redhat.com/tagoh/libhangul/libhangul-0.0.4-1.src.rpm
Here is the review: = rpmlint gives: W: libhangul-devel no-documentation but I think this is probably ok + package naming is good + spec filename matches package name + meets packaging guidelines + license is LGPL + license in spec file is correct + COPYING file is included in %doc files - I attach a small patch to improve the English descriptions + spec file is legible + md5sum matches upstream tarball a32301e03a381917cb2ec836a43a9664 libhangul-0.0.4.tar.gz + builds on fc6 i386 + no build dependencies + no translations + has correct ldconfig scripts + owns all its directories + no duplicate files in filelists + has %defattr lines + has %clean + macro use is consistent + no large documentation + %doc files do not affect runtime + has devel subpackage + devel requires pkgconfig + lib*.so is in -devel + devel package requires main package with full nvr + removes .la file + only owns its own dirs
Created attachment 148309 [details] libhangul.spec-2.patch Small patch to improve the descriptions. Sorry I should have included this in the first patch.
Ok, Take 3: Spec URL: http://people.redhat.com/tagoh/libhangul/libhangul.spec SRPM URL: http://people.redhat.com/tagoh/libhangul/libhangul-0.0.4-2.src.rpm
Thanks, srpm looks good now. Package is APPROVED.
Eeek, kind of late with the feature freeze already in effect, but I'll wave that for this (and I presume scim-hangul). I've added it to the build system. Please let me know when you've built it so I can tag it for Test3.
Thanks for adding. yes, this is for scim-hangul. I've built libhangul-0.0.4-2.fc7 and scim-hangul-0.3.1-1.fc7 into brew now.