Bug 2183700
| Summary: | Review Request: nim - A statically typed compiled systems programming language | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Felix Wang <topazus> | ||||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | benson_muite, code, dongdigua, lemenkov, package-review, petersen, sanjay.ankur | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| URL: | https://nim-lang.org/ | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | Bug | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2181693 | ||||||||
| Attachments: |
|
||||||||
|
Description
Felix Wang
2023-04-01 08:54:13 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5735135 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183700-nim/fedora-rawhide-x86_64/05735135-nim/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. SPEC URL: https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-rawhide-x86_64/05735536-nim/nim.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-rawhide-x86_64/05735536-nim/nim-1.6.10-1.fc39.src.rpm Created attachment 1955094 [details]
The .spec file difference from Copr build 5735135 to 5735583
Copr build: https://copr.fedorainfracloud.org/coprs/build/5735583 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183700-nim/fedora-rawhide-x86_64/05735583-nim/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-rawhide-x86_64/05756573-nim/nim.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-rawhide-x86_64/05756573-nim/nim-1.6.12-1.fc39.src.rpm Created attachment 1956359 [details]
The .spec file difference from Copr build 5735583 to 5758534
Copr build: https://copr.fedorainfracloud.org/coprs/build/5758534 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183700-nim/fedora-rawhide-x86_64/05758534-nim/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. 好耶! great! I also want nim to be back in Fedora again, thank you. btw, I'm unretiring nvi: https://bugzilla.redhat.com/show_bug.cgi?id=2183721 (In reply to dongdigua from comment #8) > 好耶! great! > I also want nim to be back in Fedora again, thank you. > btw, I'm unretiring nvi: https://bugzilla.redhat.com/show_bug.cgi?id=2183721 Thanks. As for the nvi unretirement, I have the similar question with Harald Reindl, since it was little commit history over the last two years, https://bugzilla.redhat.com/show_bug.cgi?id=2183721#c2 I feel you should base off the old retired package (spec file) please, unless there is a good/strong reason not to do that. Then you could also open a PR in pagure for the package unretirement as part of this review. I think that would make it easier to review and approve. https://src.fedoraproject.org/rpms/nim Latest upstream version is now 2.0, though 1.6.16 might be okay too for now? Well maybe not PR, but rather a personal pagure fork anyway. (In practice rel-eng will revert the last commit when un-retiring the package) (In reply to Jens Petersen from comment #10) > I feel you should base off the old retired package (spec file) please, > unless there is a good/strong reason not to do that. > Then you could also open a PR in pagure for the package unretirement as part > of this review. > I think that would make it easier to review and approve. > > https://src.fedoraproject.org/rpms/nim > > Latest upstream version is now 2.0, though 1.6.16 might be okay too for now? Yes, sounds like a good idea. I'd love to see another language in Fedora unretired. Please upload spec file and srpm |