Bug 2183864

Summary: Review Request: rust-x11rb - Rust bindings to X11
Product: [Fedora] Fedora Reporter: Aleksei Bavshin <alebastr89>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-02 04:01:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2183863    
Bug Blocks:    

Comment 1 Aleksei Bavshin 2023-04-23 01:19:30 UTC
Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-x11rb/rust-x11rb.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-x11rb/rust-x11rb-0.11.1-1.fc38.src.rpm

Changes:
 * Update to 0.11.1
 * Patch metadata to compile with nix 0.26

Comment 2 Fabio Valentini 2023-05-01 19:47:51 UTC
Package was generated with rust2rpm, simplifying the review.

I have used packages for missing dependencies from COPR to do this review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files is included with %license in %files (included manually from upstream, PR submitted)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fedora Admin user for bugzilla script actions 2023-05-02 02:48:22 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-x11rb

Comment 4 Fedora Update System 2023-05-02 04:00:18 UTC
FEDORA-2023-ca442cd7ca has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ca442cd7ca

Comment 5 Fedora Update System 2023-05-02 04:01:23 UTC
FEDORA-2023-ca442cd7ca has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.