Bug 2183864 - Review Request: rust-x11rb - Rust bindings to X11
Summary: Review Request: rust-x11rb - Rust bindings to X11
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2183863
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-02 19:26 UTC by Aleksei Bavshin
Modified: 2023-05-02 04:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-02 04:01:23 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Aleksei Bavshin 2023-04-23 01:19:30 UTC
Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-x11rb/rust-x11rb.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-x11rb/rust-x11rb-0.11.1-1.fc38.src.rpm

Changes:
 * Update to 0.11.1
 * Patch metadata to compile with nix 0.26

Comment 2 Fabio Valentini 2023-05-01 19:47:51 UTC
Package was generated with rust2rpm, simplifying the review.

I have used packages for missing dependencies from COPR to do this review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files is included with %license in %files (included manually from upstream, PR submitted)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fedora Admin user for bugzilla script actions 2023-05-02 02:48:22 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-x11rb

Comment 4 Fedora Update System 2023-05-02 04:00:18 UTC
FEDORA-2023-ca442cd7ca has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ca442cd7ca

Comment 5 Fedora Update System 2023-05-02 04:01:23 UTC
FEDORA-2023-ca442cd7ca has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.