Bug 2183863 - Review Request: rust-x11rb-protocol - Rust bindings to X11
Summary: Review Request: rust-x11rb-protocol - Rust bindings to X11
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2183864
TreeView+ depends on / blocked
 
Reported: 2023-04-02 19:24 UTC by Aleksei Bavshin
Modified: 2023-05-02 03:46 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-02 03:46:24 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Fabio Valentini 2023-04-20 19:40:40 UTC
The latest version of this crate is v0.11.1. Please verify that you explicitly need v0.10.0.

Comment 2 Aleksei Bavshin 2023-04-23 01:18:08 UTC
Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-x11rb-protocol/rust-x11rb-protocol.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-x11rb-protocol/rust-x11rb-protocol-0.11.1-1.fc38.src.rpm

Changes:
 * Update to 0.11.1
 * Patch metadata to compile with nix 0.26

---

> The latest version of this crate is v0.11.1. Please verify that you explicitly need v0.10.0.

Well, x11-clipboard compiles with 0.11.x if you bump the dep in Cargo.toml. The changelog mentioned some breaking changes, so I've just been wary of taking the latest version.

Comment 3 Fabio Valentini 2023-04-23 08:17:16 UTC
If you'd need to bump dependencies it's usually fine to package a slightly older version ... but if you've already confirmed that just bumping from 0.10 to 0.11 still compiles then we might as well do that 😅 I'll continue the review later today once I'm back at my PC.

Comment 4 Fabio Valentini 2023-04-23 14:56:01 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- patch is documented and justified
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
~ license files are included with %license in %files (manually included from upstream repo)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 5 Fedora Admin user for bugzilla script actions 2023-04-23 18:20:53 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-x11rb-protocol

Comment 6 Fedora Update System 2023-05-02 03:43:11 UTC
FEDORA-2023-e79d31f7b9 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e79d31f7b9

Comment 7 Fedora Update System 2023-05-02 03:46:24 UTC
FEDORA-2023-e79d31f7b9 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.