Bug 2183869

Summary:	Review Request: rust-owned_ttf_parser - Ttf-parser plus support for owned data
Product:	[Fedora] Fedora	Reporter:	Aleksei Bavshin <alebastr89>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-owned_ttf_parser-0.18.1-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-03 06:17:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2130542
Bug Blocks:	2183874

Description Aleksei Bavshin 2023-04-02 19:49:53 UTC

Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-owned_ttf_parser/rust-owned_ttf_parser.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-owned_ttf_parser/rust-owned_ttf_parser-0.18.1-1.fc38.src.rpm
Copr: https://copr.fedorainfracloud.org/coprs/alebastr/rust-alacritty/
Description:
Ttf-parser plus support for owned data.

Fedora Account System Username: alebastr

Note: this is a re-review for a package that was retired more than 8 weeks ago

Comment 1 Fabio Valentini 2023-05-01 18:57:52 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (v0.18.* is explicitly needed)
- license matches upstream specification (Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- test fixtures with different licenses excluded from installed files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

I am currently main point of contact of this package, but I agree to having this package unretired and to the transfer of ownership to alebastr.

Comment 2 Fabio Valentini 2023-05-02 22:23:13 UTC

I've manually transferred ownership to you.

Looks like the unretirement scripts were changed to only do that automatically if the previous maintainer is "orphan"? (That's probably my fault, I complained about "hostile takeover" of a few of my packages recently, where I still maintained packages in stable branches but they had been retired in rawhide ...)

Comment 3 Aleksei Bavshin 2023-05-03 06:17:47 UTC

Thanks!

Rawhide update: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6c4028fad9