Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-ab_glyph/rust-ab_glyph.spec SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-ab_glyph/rust-ab_glyph-0.2.20-1.fc38.src.rpm Copr: https://copr.fedorainfracloud.org/coprs/alebastr/rust-alacritty/ Description: API for loading, scaling, positioning and rasterizing OpenType font glyphs. Fedora Account System Username: alebastr Note: this is a re-review for a package that was retired more than 8 weeks ago
Package was generated with rust2rpm, simplifying the review. Review was finished using built dependencies from the linked COPR. - package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (there are no unit tests, and doctests are enabled) ! latest version of the crate is packaged (v0.2.20 -> v0.2.21) - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Please just disable tests entirely (i.e. %bcond_without -> %bcond_with). There are no unit tests, and doctests are disabled, so flipping the bcond would be easier. Note that v0.2.21 is now the latest version, but it depends on owned_ttf_parser -> ttf-parser v0.19, which are not updated yet, so keeping this package at v0.2.20 until the other two packages can be updated is fine.
Thanks for the review! Addressed the tests comment and built for rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0c17fac85a