Bug 2183869 - Review Request: rust-owned_ttf_parser - Ttf-parser plus support for owned data
Summary: Review Request: rust-owned_ttf_parser - Ttf-parser plus support for owned data
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2130542
Blocks: 2183874
TreeView+ depends on / blocked
 
Reported: 2023-04-02 19:49 UTC by Aleksei Bavshin
Modified: 2023-05-03 06:17 UTC (History)
2 users (show)

Fixed In Version: rust-owned_ttf_parser-0.18.1-1.fc39
Clone Of:
Environment:
Last Closed: 2023-05-03 06:17:47 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Aleksei Bavshin 2023-04-02 19:49:53 UTC
Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-owned_ttf_parser/rust-owned_ttf_parser.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-owned_ttf_parser/rust-owned_ttf_parser-0.18.1-1.fc38.src.rpm
Copr: https://copr.fedorainfracloud.org/coprs/alebastr/rust-alacritty/
Description:
Ttf-parser plus support for owned data.

Fedora Account System Username: alebastr

Note: this is a re-review for a package that was retired more than 8 weeks ago

Comment 1 Fabio Valentini 2023-05-01 18:57:52 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (v0.18.* is explicitly needed)
- license matches upstream specification (Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- test fixtures with different licenses excluded from installed files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

I am currently main point of contact of this package, but I agree to having this package unretired and to the transfer of ownership to alebastr.

Comment 2 Fabio Valentini 2023-05-02 22:23:13 UTC
I've manually transferred ownership to you.

Looks like the unretirement scripts were changed to only do that automatically if the previous maintainer is "orphan"? (That's probably my fault, I complained about "hostile takeover" of a few of my packages recently, where I still maintained packages in stable branches but they had been retired in rawhide ...)

Comment 3 Aleksei Bavshin 2023-05-03 06:17:47 UTC
Thanks!

Rawhide update: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6c4028fad9


Note You need to log in before you can comment on or make changes to this bug.