Bug 2183874

Summary:	Review Request: rust-ab_glyph - API for loading, scaling, positioning and rasterizing OpenType font glyphs
Product:	[Fedora] Fedora	Reporter:	Aleksei Bavshin <alebastr89>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-ab_glyph-0.2.20-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-03 06:30:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2183869, 2183873
Bug Blocks:	2183860

Description Aleksei Bavshin 2023-04-02 20:08:45 UTC

Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-ab_glyph/rust-ab_glyph.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-ab_glyph/rust-ab_glyph-0.2.20-1.fc38.src.rpm
Copr: https://copr.fedorainfracloud.org/coprs/alebastr/rust-alacritty/
Description:
API for loading, scaling, positioning and rasterizing OpenType font
glyphs.

Fedora Account System Username: alebastr

Note: this is a re-review for a package that was retired more than 8 weeks ago

Comment 1 Fabio Valentini 2023-05-01 19:08:33 UTC

Package was generated with rust2rpm, simplifying the review.

Review was finished using built dependencies from the linked COPR.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (there are no unit tests, and doctests are enabled)
! latest version of the crate is packaged (v0.2.20 -> v0.2.21)
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Please just disable tests entirely (i.e. %bcond_without -> %bcond_with).
There are no unit tests, and doctests are disabled, so flipping the bcond would be easier.

Note that v0.2.21 is now the latest version, but it depends on owned_ttf_parser -> ttf-parser v0.19, which are not updated yet, so keeping this package at v0.2.20 until the other two packages can be updated is fine.

Comment 2 Aleksei Bavshin 2023-05-03 06:30:35 UTC

Thanks for the review!

Addressed the tests comment and built for rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0c17fac85a