Bug 2224713 (golang-github-apapsch-jsonmerge-2)
| Summary: | Review Request: golang-github-apapsch-jsonmerge-2 - Merge JSON objects | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert-André Mauchin 🐧 <eclipseo> | ||||
| Component: | Package Review | Assignee: | Pavel Solovev <daron439> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | daron439, package-review | ||||
| Target Milestone: | --- | Flags: | daron439:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | golang-github-apapsch-jsonmerge-2-2.0.0-1.fc40 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-08-28 01:29:19 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2224692 | ||||||
| Bug Blocks: | 2224860 | ||||||
| Attachments: |
|
||||||
|
Description
Robert-André Mauchin 🐧
2023-07-22 11:30:40 UTC
> %gobuild -o %{gobuilddir}/bin/jsonmerge %{goipath}/cmd
fails to build with the following error:
package github.com/apapsch/go-jsonmerge/v2/cmd: no Go files in /builddir/build/BUILD/go-jsonmerge-2.0.0/_build/src/github.com/apapsch/go-jsonmerge/v2/cmd
Should be %gobuild -o %{gobuilddir}/bin/jsonmerge %{goipath}/cmd/jsonmerge
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-apapsch-jsonmerge-2.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-apapsch-jsonmerge-2-2.0.0-1.fc38.src.rpm Thanks, I had uploaded the wrong version. Created attachment 1981215 [details]
The .spec file difference from Copr build 6203387 to 6232531
Golang Package Review
==============
This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-apapsch-jsonmerge-2 FEDORA-2023-d1d8958161 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d1d8958161 FEDORA-2023-17923dff13 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-17923dff13 FEDORA-2023-d1d8958161 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-d1d8958161 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-d1d8958161 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-17923dff13 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-17923dff13 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-17923dff13 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-83d5515497 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-83d5515497 FEDORA-2023-83d5515497 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-83d5515497 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-83d5515497 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-d1d8958161 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-17923dff13 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-83d5515497 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |