Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge-1.0.0-1.fc38.src.rpm Description: Merge JSON objects to one (replaces only existent values). Fedora Account System Username: eclipseo
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge-1.0.0-1.20230722gitfbb4398.fc38.src.rpm
Created attachment 1977045 [details] The .spec file difference from Copr build 6202986 to 6203326
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-ravenox-jsonmerge-1.0.0-1.20230722git0828c73.fc38.src.rpm
Created attachment 1977046 [details] The .spec file difference from Copr build 6203326 to 6203370
Created attachment 1977047 [details] The .spec file difference from Copr build 6203370 to 6203378
The jsonmerge binary will conflict with https://bugzilla.redhat.com/show_bug.cgi?id=2224713. Is it needed here?
Indeed, thanks.
Golang Package Review ============== This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The specfile is sane. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-ravenox-jsonmerge