Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-apapsch-jsonmerge-2.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-apapsch-jsonmerge-2-2.0.0-1.fc38.src.rpm Description: Merge JSON objects. Fedora Account System Username: eclipseo
> %gobuild -o %{gobuilddir}/bin/jsonmerge %{goipath}/cmd fails to build with the following error: package github.com/apapsch/go-jsonmerge/v2/cmd: no Go files in /builddir/build/BUILD/go-jsonmerge-2.0.0/_build/src/github.com/apapsch/go-jsonmerge/v2/cmd Should be %gobuild -o %{gobuilddir}/bin/jsonmerge %{goipath}/cmd/jsonmerge
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-apapsch-jsonmerge-2.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-apapsch-jsonmerge-2-2.0.0-1.fc38.src.rpm
Thanks, I had uploaded the wrong version.
Created attachment 1981215 [details] The .spec file difference from Copr build 6203387 to 6232531
Golang Package Review ============== This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The specfile is sane. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-apapsch-jsonmerge-2