Bug 2227433
| Summary: | Review Request: golang-github-poy-onpar - Parallel testing framework for Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-02 09:12:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2113315, 2227434 | ||
|
Description
Davide Cavalca
2023-07-29 16:13:25 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=104098587 Why don't you use :
%generate_buildrequires
%go_generate_buildrequires
instead of :
%if %{with check}
# Tests
BuildRequires: golang(git.sr.ht/~nelsam/hel/pkg/pers)
BuildRequires: golang(git.sr.ht/~nelsam/hel/vegr)
BuildRequires: golang(github.com/fatih/color)
%endif
- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
- Conforms to Go Packaging Guidelines
Please check what I said above and I'll approve.
(Please needinfo me for the followup) Because there's a circular dependency between this and golang-sr-nelsam-hel, and when I was using dynamic BRs it kept trying to install the latter even with tests disabled. Once both are in I'll switch this back to using dynamic BRs. Ok, package approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-poy-onpar FEDORA-2023-98c6ea8a42 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-98c6ea8a42 FEDORA-2023-98c6ea8a42 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-b70a4d44aa has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b70a4d44aa FEDORA-2023-8149bd9c52 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8149bd9c52 FEDORA-2023-b70a4d44aa has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b70a4d44aa \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b70a4d44aa See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-8149bd9c52 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8149bd9c52 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8149bd9c52 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-8149bd9c52 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-b70a4d44aa has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |