Bug 2227433 - Review Request: golang-github-poy-onpar - Parallel testing framework for Go
Summary: Review Request: golang-github-poy-onpar - Parallel testing framework for Go
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2113315 2227434
TreeView+ depends on / blocked
 
Reported: 2023-07-29 16:13 UTC by Davide Cavalca
Modified: 2023-08-06 01:41 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-08-02 09:12:06 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-07-29 16:13:25 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-poy-onpar/golang-github-poy-onpar.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-poy-onpar/golang-github-poy-onpar-0.3.2-1.fc39.src.rpm

Description:
Parallel testing framework for Go.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-07-29 16:13:27 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=104098587

Comment 2 Robert-André Mauchin 🐧 2023-07-30 08:43:18 UTC
Why don't you use :

%generate_buildrequires
%go_generate_buildrequires

instead of :

%if %{with check}
# Tests
BuildRequires:  golang(git.sr.ht/~nelsam/hel/pkg/pers)
BuildRequires:  golang(git.sr.ht/~nelsam/hel/vegr)
BuildRequires:  golang(github.com/fatih/color)
%endif


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Go Packaging Guidelines


Please check what I said above and I'll approve.

Comment 3 Robert-André Mauchin 🐧 2023-07-30 08:49:45 UTC
(Please needinfo me for the followup)

Comment 4 Davide Cavalca 2023-07-30 15:22:54 UTC
Because there's a circular dependency between this and golang-sr-nelsam-hel, and when I was using dynamic BRs it kept trying to install the latter even with tests disabled. Once both are in I'll switch this back to using dynamic BRs.

Comment 5 Robert-André Mauchin 🐧 2023-08-01 20:07:13 UTC
Ok, package approved.

Comment 6 Fedora Admin user for bugzilla script actions 2023-08-02 08:58:09 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-poy-onpar

Comment 7 Fedora Update System 2023-08-02 09:09:31 UTC
FEDORA-2023-98c6ea8a42 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-98c6ea8a42

Comment 8 Fedora Update System 2023-08-02 09:12:06 UTC
FEDORA-2023-98c6ea8a42 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-08-02 13:42:18 UTC
FEDORA-2023-b70a4d44aa has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b70a4d44aa

Comment 10 Fedora Update System 2023-08-02 15:49:54 UTC
FEDORA-2023-8149bd9c52 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8149bd9c52

Comment 11 Fedora Update System 2023-08-03 01:21:44 UTC
FEDORA-2023-b70a4d44aa has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b70a4d44aa \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b70a4d44aa

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-08-03 01:43:17 UTC
FEDORA-2023-8149bd9c52 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8149bd9c52 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8149bd9c52

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-08-06 00:38:50 UTC
FEDORA-2023-8149bd9c52 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-08-06 01:41:00 UTC
FEDORA-2023-b70a4d44aa has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.