Spec URL: https://dcavalca.fedorapeople.org/review/golang-sr-nelsam-hel/golang-sr-nelsam-hel.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-sr-nelsam-hel/golang-sr-nelsam-hel-0.4.6-1.fc39.src.rpm Description: Hel is the norse goddess that rules over Helheim, where the souls of those who did not die in battle go. This little tool is similar; it generates (hopefully simple) mocks of Go interface types and stores them in helheim_test.go (by default). Fedora Account System Username: dcavalca
I'd suggest you rename your package to 'hel'. I don't think you need the library files either, so you could get rid of : %gopkg %gopkginstall %gopkgfiles and just keep the binary. > {_bindir}/* Please specify the binary name instead of a glob: {_bindir}/hel - License ok - Latest version packaged - Builds in mock - Checks pass - No rpmlint errors - Conforms to Go Packaging Guidelines Please take into account my comments and get back to me with a needinfo.
The libraries are needed for the tests in golang-github-poy-onpar. I'll rename the binary package but I'd rather keep the source package name as-is to follow the convention. Will fix the globbing, thanks.
Package approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-sr-nelsam-hel
FEDORA-2023-888229e974 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-888229e974
FEDORA-2023-888229e974 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-862d428146 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-862d428146
FEDORA-2023-862d428146 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.