Bug 2227434

Summary:	Review Request: golang-sr-nelsam-hel - Mock generator for Go
Product:	[Fedora] Fedora	Reporter:	Davide Cavalca <davide>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-12 16:18:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2227433
Bug Blocks:

Description Davide Cavalca 2023-07-29 16:13:56 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/golang-sr-nelsam-hel/golang-sr-nelsam-hel.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-sr-nelsam-hel/golang-sr-nelsam-hel-0.4.6-1.fc39.src.rpm

Description:
Hel is the norse goddess that rules over Helheim, where the souls of those who
did not die in battle go.

This little tool is similar; it generates (hopefully simple) mocks of Go
interface types and stores them in helheim_test.go (by default).

Fedora Account System Username: dcavalca

Comment 1 Robert-André Mauchin 🐧 2023-07-30 08:48:59 UTC

I'd suggest you rename your package to 'hel'.

I don't think you need the library files either, so you could get rid of :

%gopkg

%gopkginstall

%gopkgfiles


and just keep the binary.


> {_bindir}/*

Please specify the binary name instead of a glob:

{_bindir}/hel




 - License ok
 - Latest version packaged
 - Builds in mock
 - Checks pass
 - No rpmlint errors
 - Conforms to Go Packaging Guidelines


Please take into account my comments and get back to me with a needinfo.

Comment 2 Davide Cavalca 2023-07-30 15:24:16 UTC

The libraries are needed for the tests in golang-github-poy-onpar. I'll rename the binary package but I'd rather keep the source package name as-is to follow the convention. Will fix the globbing, thanks.

Comment 3 Robert-André Mauchin 🐧 2023-08-01 20:07:51 UTC

Package approved.

Comment 4 Fedora Admin user for bugzilla script actions 2023-08-12 16:04:03 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-sr-nelsam-hel

Comment 5 Fedora Update System 2023-08-12 16:17:39 UTC

FEDORA-2023-888229e974 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-888229e974

Comment 6 Fedora Update System 2023-08-12 16:18:38 UTC

FEDORA-2023-888229e974 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2023-08-12 16:29:54 UTC

FEDORA-2023-862d428146 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-862d428146

Comment 8 Fedora Update System 2023-08-12 16:30:38 UTC

FEDORA-2023-862d428146 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.