Bug 2228231 (golang-github-mdlayher-packet)

Summary:	Review Request: golang-github-mdlayher-packet - Package packet provides access to Linux packet sockets (AF_PACKET)
Product:	[Fedora] Fedora	Reporter:	Robert-André Mauchin 🐧 <zebob.m>
Component:	Package Review	Assignee:	Pavel Solovev <daron439>
Status:	POST ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	daron439, package-review
Target Milestone:	---	Flags:	daron439: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robert-André Mauchin 🐧 2023-08-01 18:57:42 UTC

Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-mdlayher-packet.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-mdlayher-packet-1.1.2-1.fc38.src.rpm

Description:
Package packet provides access to Linux packet sockets (AF_PACKET). MIT Licensed.

Fedora Account System Username: eclipseo

Comment 1 Robert-André Mauchin 🐧 2023-08-01 19:06:40 UTC

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=104234750

Comment 2 Pavel Solovev 2023-08-02 07:43:24 UTC

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!