Bug 2228231 (golang-github-mdlayher-packet) - Review Request: golang-github-mdlayher-packet - Package packet provides access to Linux packet sockets (AF_PACKET)
Summary: Review Request: golang-github-mdlayher-packet - Package packet provides acces...
Keywords:
Status: CLOSED DUPLICATE of bug 2260164
Alias: golang-github-mdlayher-packet
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pavel Solovev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-08-01 18:57 UTC by Robert-André Mauchin 🐧
Modified: 2024-01-24 18:29 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-24 18:29:32 UTC
Type: ---
Embargoed:
daron439: fedora-review+


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2023-08-01 18:57:42 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-mdlayher-packet.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-mdlayher-packet-1.1.2-1.fc38.src.rpm

Description:
Package packet provides access to Linux packet sockets (AF_PACKET). MIT Licensed.

Fedora Account System Username: eclipseo

Comment 1 Robert-André Mauchin 🐧 2023-08-01 19:06:40 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=104234750

Comment 2 Pavel Solovev 2023-08-02 07:43:24 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 3 Davide Cavalca 2024-01-24 18:29:32 UTC
Looks like this was never imported, and I need it to resolve a FTBFS, so I put it up in https://bugzilla.redhat.com/show_bug.cgi?id=2260164 again. Happy to add you as co-maintainer.

*** This bug has been marked as a duplicate of bug 2260164 ***


Note You need to log in before you can comment on or make changes to this bug.