Bug 2260164 - Review Request: golang-github-mdlayher-packet - Provides access to Linux packet sockets (AF_PACKET)
Summary: Review Request: golang-github-mdlayher-packet - Provides access to Linux pack...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pavel Solovev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: golang-github-mdlayher-packet (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-01-24 18:28 UTC by Davide Cavalca
Modified: 2024-01-24 20:48 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-24 20:48:13 UTC
Type: ---
Embargoed:
daron439: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-01-24 18:28:28 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-mdlayher-packet/golang-github-mdlayher-packet.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-mdlayher-packet/golang-github-mdlayher-packet-1.1.2-1.fc40.src.rpm

Description:
Package packet provides access to Linux packet sockets (AF_PACKET). MIT
Licensed.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-01-24 18:28:30 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=112284989

Comment 2 Davide Cavalca 2024-01-24 18:29:32 UTC
*** Bug 2228231 has been marked as a duplicate of this bug. ***

Comment 3 Fedora Review Service 2024-01-24 18:33:41 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6947496
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260164-golang-github-mdlayher-packet/fedora-rawhide-x86_64/06947496-golang-github-mdlayher-packet/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Pavel Solovev 2024-01-24 19:43:44 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 5 Fedora Admin user for bugzilla script actions 2024-01-24 20:33:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-mdlayher-packet

Comment 6 Fedora Update System 2024-01-24 20:45:34 UTC
FEDORA-2024-26715056bb has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-26715056bb

Comment 7 Fedora Update System 2024-01-24 20:48:13 UTC
FEDORA-2024-26715056bb has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.