Bug 2231393
Summary: | Review Request: golang-modernc-libc - Runtime services for Go without cgo | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> | ||||
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | package-review, zebob.m | ||||
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2023-08-20 20:28:06 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 2231392 | ||||||
Bug Blocks: | 2231928, 2231930, 2231933, 2231945 | ||||||
Attachments: |
|
Description
W. Michael Petullo
2023-08-11 13:25:11 UTC
Clean up this: %global golicenses LICENSE LICENSE-GO honnef.co/go/netdb/LICENSE\\\ musl/COPYRIGHT %global godocs AUTHORS CONTRIBUTORS README.md\\\ honnef.co/go/netdb/README.md musl/README -> %global golicenses LICENSE LICENSE-GO LICENSE-honnef\\\ COPYRIGHT-musl %global godocs AUTHORS CONTRIBUTORS README.md and : %license LICENSE LICENSE-GO honnef.co/go/netdb/LICENSE musl/COPYRIGHT %doc AUTHORS CONTRIBUTORS README.md honnef.co/go/netdb/README.md musl/README -> %license LICENSE LICENSE-GO LICENSE-honnef COPYRIGHT-musl %doc AUTHORS CONTRIBUTORS README.md with: %prep %goprep %autopatch -p1 mv honnef.co/go/netdb/LICENSE LICENSE-honnef mv musl/COPYRIGHT COPYRIGHT-musl - Add the license breakdown: Name: %{goname} Release: %autorelease Summary: C-runtime services for Go without cgo # BSD-3-Clause: main program # MIT: musl/ and honnef.co/ License: BSD-3-Clause AND MIT URL: %{gourl} Source: %{gosource} - Do not glob the entire bindir/ %{_bindir}/libc Besides, do you really need the binary for any project? Is it wise to include it? Needinfo me when updated. Spec URL: https://www.flyn.org/SRPMS/golang-modernc-libc.spec SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-libc-1.24.1-1.fc38.src.rpm Followed suggestions above, and removed binary from package. How do I prevent the macros from building the binary package, which includes only documentation? Created attachment 1983424 [details]
The .spec file difference from Copr build 6266433 to 6299746
> How do I prevent the macros from building the binary package, which includes only documentation?
Macros or go2rpm? go2rpm has no provision for that, you edit the file manually.
- Remove v2 in prep:
rm -rfv v2/
- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines
Package approved.
Please:
- add commit rights to go-sig after requesting the repo
- add the package to Koschei in the go-sig group on all branches you are building
- add the package to release-monitoring.org even if it does not release version
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-libc FEDORA-2023-2b44a09773 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2b44a09773 FEDORA-2023-2b44a09773 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |