Bug 2231933

Summary:	Review Request: golang-modernc-tcl - Tcl (Tool Command Language) for Go without cgo
Product:	[Fedora] Fedora	Reporter:	W. Michael Petullo <mike>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-20 20:11:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2231393, 2231928, 2231930
Bug Blocks:	2231945

Description W. Michael Petullo 2023-08-14 17:40:50 UTC

Spec URL: https://www.flyn.org/SRPMS/golang-modernc-tcl.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-tcl-1.15.3-1.fc38.src.rpm
Description: Tcl (Tool Command Language) for Go without cgo
Fedora Account System Username:

COPR repository:
[copr:copr.fedorainfracloud.org:mikep:golang]
name=Copr repo for golang owned by mikep
baseurl=https://download.copr.fedorainfracloud.org/results/mikep/golang/fedora-$releasever-$basearch/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/golang/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 Robert-André Mauchin 🐧 2023-08-20 17:51:08 UTC

 - We don't need this:

for cmd in gotclsh; do
  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
done

  - Don't glob the entire binary directory:

%{_bindir}/tcl

- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version

Comment 2 Fedora Admin user for bugzilla script actions 2023-08-20 20:05:20 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-tcl

Comment 3 Fedora Update System 2023-10-04 01:27:19 UTC

FEDORA-2023-5a4f0c376f has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a4f0c376f

Comment 4 Fedora Update System 2023-10-04 01:28:09 UTC

FEDORA-2023-5a4f0c376f has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.