Bug 2238117

Summary: Review Request: python-pydantic-core - Core validation logic for pydantic written in rust
Product: [Fedora] Fedora Reporter: Maxwell G <maxwell>
Component: Package ReviewAssignee: Daniel Milnes <daniel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: daniel, package-review
Target Milestone: ---Flags: daniel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-11 16:22:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2238103, 2238116    
Bug Blocks: 2157134    
Attachments:
Description Flags
fedora-review output
none
completed fedora-review output none

Description Maxwell G 2023-09-09 04:34:27 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/gotmax23/pydanticv2/fedora-rawhide-x86_64/06388956-python-pydantic-core/python-pydantic-core.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/gotmax23/pydanticv2/fedora-rawhide-x86_64/06388956-python-pydantic-core/python-pydantic-core-2.6.3-1.fc40.src.rpm
Description: The pydantic-core project provides the core validation logic for pydantic
written in Rust.
Fedora Account System Username gotmax23
Comment 1 Daniel Milnes 2023-09-10 23:42:37 UTC 
Hey Maxwell,

APPROVED from my side. I'd suggest swapping to %autorelease and %autochangelog, but I wont block approval behind that.

If you've got a second, would you be able to take a glance at Bug 2238191 for me please?

Thanks.
Comment 2 Daniel Milnes 2023-09-10 23:43:58 UTC 
Created attachment 1988067 [details]
fedora-review output
Comment 3 Maxwell G 2023-09-11 02:38:48 UTC 
Thanks for the review, Daniel! Do note that you should fill out the review template and paste it into the comment, not just attach the blank version. I will import this package and review yours tomorrow.
Comment 4 Fedora Admin user for bugzilla script actions 2023-09-11 02:39:23 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pydantic-core
Comment 5 Daniel Milnes 2023-09-11 06:12:04 UTC 
Hey Maxwell,

(In reply to Maxwell G from comment #3)
> Thanks for the review, Daniel! Do note that you should fill out the review
> template and paste it into the comment, not just attach the blank version.

Whoops, helps if I actually upload the right version of the review.txt. See attached for the fixed version, sorry about that.

> I will import this package and review yours tomorrow.

Thank you for this. Reading my message back, I'm not happy with the tone of it. I was a bit presumptuous, so please accept my apologies and don't worry about reviewing my bug if you don't want to.

Thanks for your understanding.
Comment 6 Daniel Milnes 2023-09-11 06:12:30 UTC 
Created attachment 1988085 [details]
completed fedora-review output
Comment 7 Fedora Update System 2023-09-11 16:21:03 UTC 
FEDORA-2023-d26cc533c1 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d26cc533c1
Comment 8 Fedora Update System 2023-09-11 16:22:34 UTC 
FEDORA-2023-d26cc533c1 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.