Bug 2238117 - Review Request: python-pydantic-core - Core validation logic for pydantic written in rust
Summary: Review Request: python-pydantic-core - Core validation logic for pydantic wri...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Daniel Milnes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2238103 2238116
Blocks: 2157134
TreeView+ depends on / blocked
 
Reported: 2023-09-09 04:34 UTC by Maxwell G
Modified: 2023-09-12 23:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-09-11 16:22:34 UTC
Type: ---
Embargoed:
daniel: fedora-review+


Attachments (Terms of Use)
fedora-review output (10.47 KB, text/plain)
2023-09-10 23:43 UTC, Daniel Milnes
no flags Details
completed fedora-review output (10.02 KB, text/plain)
2023-09-11 06:12 UTC, Daniel Milnes
no flags Details

Comment 1 Daniel Milnes 2023-09-10 23:42:37 UTC
Hey Maxwell,

APPROVED from my side. I'd suggest swapping to %autorelease and %autochangelog, but I wont block approval behind that.

If you've got a second, would you be able to take a glance at Bug 2238191 for me please?

Thanks.

Comment 2 Daniel Milnes 2023-09-10 23:43:58 UTC
Created attachment 1988067 [details]
fedora-review output

Comment 3 Maxwell G 2023-09-11 02:38:48 UTC
Thanks for the review, Daniel! Do note that you should fill out the review template and paste it into the comment, not just attach the blank version. I will import this package and review yours tomorrow.

Comment 4 Fedora Admin user for bugzilla script actions 2023-09-11 02:39:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pydantic-core

Comment 5 Daniel Milnes 2023-09-11 06:12:04 UTC
Hey Maxwell,

(In reply to Maxwell G from comment #3)
> Thanks for the review, Daniel! Do note that you should fill out the review
> template and paste it into the comment, not just attach the blank version.

Whoops, helps if I actually upload the right version of the review.txt. See attached for the fixed version, sorry about that.

> I will import this package and review yours tomorrow.

Thank you for this. Reading my message back, I'm not happy with the tone of it. I was a bit presumptuous, so please accept my apologies and don't worry about reviewing my bug if you don't want to.

Thanks for your understanding.

Comment 6 Daniel Milnes 2023-09-11 06:12:30 UTC
Created attachment 1988085 [details]
completed fedora-review output

Comment 7 Fedora Update System 2023-09-11 16:21:03 UTC
FEDORA-2023-d26cc533c1 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d26cc533c1

Comment 8 Fedora Update System 2023-09-11 16:22:34 UTC
FEDORA-2023-d26cc533c1 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.