Bug 2238116 - Review Request: rust-enum_dispatch - Near drop-in replacement for dynamic-dispatched method calls with up to 10x the speed
Summary: Review Request: rust-enum_dispatch - Near drop-in replacement for dynamic-dis...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2238117
TreeView+ depends on / blocked
 
Reported: 2023-09-09 04:33 UTC by Maxwell G
Modified: 2023-09-18 01:37 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-09-09 19:55:35 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 2 Fabio Valentini 2023-09-09 14:02:31 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (disabled with explanation)
! latest version of the crate is packaged (v0.3.11 vs. v0.3.12)
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Upstream has released v0.3.12 two months ago, is there a reason why you've packaged v0.3.11?
If not, please update to the latest version ASAP (before or after importing does not matter to me).

Comment 3 Maxwell G 2023-09-09 19:42:29 UTC
Thanks for the review!

> Upstream has released v0.3.12 two months ago, is there a reason why you've packaged v0.3.11?

No, I'll fix on import.

Comment 4 Fedora Admin user for bugzilla script actions 2023-09-09 19:43:07 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-enum_dispatch

Comment 5 Fedora Update System 2023-09-09 19:52:38 UTC
FEDORA-2023-cb5dcec7b7 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-cb5dcec7b7

Comment 6 Fedora Update System 2023-09-09 19:55:35 UTC
FEDORA-2023-cb5dcec7b7 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2023-09-09 19:55:51 UTC
FEDORA-2023-64f6f69cf9 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-64f6f69cf9

Comment 8 Fedora Update System 2023-09-09 19:56:07 UTC
FEDORA-2023-8ad34e7f1b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8ad34e7f1b

Comment 9 Fedora Update System 2023-09-09 19:56:18 UTC
FEDORA-2023-a792d0a666 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a792d0a666

Comment 10 Fedora Update System 2023-09-10 01:34:38 UTC
FEDORA-2023-a792d0a666 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a792d0a666 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a792d0a666

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-09-10 01:51:24 UTC
FEDORA-2023-64f6f69cf9 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-64f6f69cf9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-64f6f69cf9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-09-10 02:16:20 UTC
FEDORA-2023-8ad34e7f1b has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8ad34e7f1b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8ad34e7f1b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-09-15 18:56:03 UTC
FEDORA-2023-64f6f69cf9 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-09-18 01:24:43 UTC
FEDORA-2023-8ad34e7f1b has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2023-09-18 01:37:24 UTC
FEDORA-2023-a792d0a666 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.