Bug 2246011
| Summary: | Review Request: rust-schemars_derive - Macros for #[derive(JsonSchema)], for use with schemars | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | fedora.dm0 |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora.dm0, package-review |
| Target Milestone: | --- | Flags: | fedora.dm0:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-11-23 00:09:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2246010 | ||
| Bug Blocks: | 2246014 | ||
|
Description
Fabio Valentini
2023-10-24 23:28:35 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6563220 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246011-rust-schemars_derive/srpm-builds/06563220/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=108660677 Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is NOT packaged (see note) - license matches upstream specification (MIT, see note) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === A new version was released that only contains one small change. Upgrading just consists of bumping the version number, and everything still seems to work as before. === Functions in the file src/regex_syntax.rs are taken from the regex_syntax crate which is licensed as "MIT OR Apache-2.0". It seems this crate drops Apache-2.0 to redistribute the code and adds only the MIT license to the file header, so presumably the RPM can be MIT-only as it is. Thanks for the review! I'll try to update to the latest version ASAP. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-schemars_derive FEDORA-2023-0c864830f5 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0c864830f5 FEDORA-2023-0c864830f5 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |