Bug 2246011 - Review Request: rust-schemars_derive - Macros for #[derive(JsonSchema)], for use with schemars
Summary: Review Request: rust-schemars_derive - Macros for #[derive(JsonSchema)], for ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: fedora.dm0
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2246010
Blocks: 2246014
TreeView+ depends on / blocked
 
Reported: 2023-10-24 23:28 UTC by Fabio Valentini
Modified: 2023-11-23 00:09 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-23 00:09:39 UTC
Type: ---
Embargoed:
fedora.dm0: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-10-24 23:28:35 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-schemars_derive.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-schemars_derive-0.8.15-1.fc39.src.rpm

Description:
Macros for #[derive(JsonSchema)], for use with schemars.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2023-10-25 02:32:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6563220
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246011-rust-schemars_derive/srpm-builds/06563220/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-11-06 16:35:26 UTC
koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=108660677

Comment 3 fedora.dm0 2023-11-22 15:09:44 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is NOT packaged (see note)
- license matches upstream specification (MIT, see note) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

A new version was released that only contains one small change.  Upgrading just consists of bumping the version number, and everything still seems to work as before.

===

Functions in the file src/regex_syntax.rs are taken from the regex_syntax crate which is licensed as "MIT OR Apache-2.0".  It seems this crate drops Apache-2.0 to redistribute the code and adds only the MIT license to the file header, so presumably the RPM can be MIT-only as it is.

Comment 4 Fabio Valentini 2023-11-22 23:03:52 UTC
Thanks for the review! I'll try to update to the latest version ASAP.

Comment 5 Fedora Admin user for bugzilla script actions 2023-11-22 23:05:39 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-schemars_derive

Comment 6 Fedora Update System 2023-11-23 00:08:03 UTC
FEDORA-2023-0c864830f5 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0c864830f5

Comment 7 Fedora Update System 2023-11-23 00:09:39 UTC
FEDORA-2023-0c864830f5 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.