Bug 2249519

Summary: Review Request: rust-snap - Pure Rust implementation of the Snappy compression algorithm
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-13 18:33:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1276941, 2246802, 2249520    

Description Ben Beasley 2023-11-13 16:14:38 UTC
Spec URL: https://music.fedorapeople.org/rust-snap.spec
SRPM URL: https://music.fedorapeople.org/rust-snap-1.1.0-1.fc39.src.rpm
Description:

A pure Rust implementation of the Snappy compression algorithm. Includes
streaming compression and decompression.

Fedora Account System Username: music

The spec file is unmodified rust2rpm output.

Koji scratch builds:

F40: https://koji.fedoraproject.org/koji/taskinfo?taskID=108977481
F39: https://koji.fedoraproject.org/koji/taskinfo?taskID=108977482
F38: https://koji.fedoraproject.org/koji/taskinfo?taskID=108977492

Comment 1 Ben Beasley 2023-11-13 16:21:38 UTC
Blocking neuro-fedora since this is a dependency for python-cramjam, which is required for updating python-fastavro. This will be a neuro-sig package.

Comment 2 Fedora Review Service 2023-11-13 17:36:56 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6630303
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249519-rust-snap/srpm-builds/06630303/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2023-11-13 18:06:03 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (BSD-3-Clause) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

If you have time, it would be great if you could review one of my pending packages in turn.

Comment 4 Fedora Admin user for bugzilla script actions 2023-11-13 18:15:16 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-snap

Comment 5 Ben Beasley 2023-11-13 18:17:51 UTC
Thank you for the review!

I’ll try to find a straightforward enough Rust package to review in turn.

Comment 6 Ben Beasley 2023-11-13 18:22:28 UTC
I have configured release monitoring[1], given rust-sig and neuro-sig commit privileges, and enabled Koschei.

[1] https://release-monitoring.org/project/370205/

Comment 7 Fabio Valentini 2023-11-13 18:25:51 UTC
Perfect, thanks!

Comment 8 Fedora Update System 2023-11-13 18:32:56 UTC
FEDORA-2023-752479b0b4 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-752479b0b4

Comment 9 Fedora Update System 2023-11-13 18:33:41 UTC
FEDORA-2023-752479b0b4 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2023-11-14 12:03:04 UTC
FEDORA-2023-c951664334 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c951664334

Comment 11 Fedora Update System 2023-11-14 12:27:45 UTC
FEDORA-2023-1e0e93fe68 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1e0e93fe68

Comment 12 Fedora Update System 2023-11-14 13:12:19 UTC
FEDORA-EPEL-2023-75445c8ae4 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-75445c8ae4

Comment 13 Fedora Update System 2023-11-15 03:24:34 UTC
FEDORA-2023-1e0e93fe68 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-1e0e93fe68 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-1e0e93fe68

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2023-11-15 03:51:17 UTC
FEDORA-EPEL-2023-75445c8ae4 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-75445c8ae4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2023-11-15 04:06:57 UTC
FEDORA-2023-c951664334 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c951664334 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c951664334

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2023-11-23 01:23:11 UTC
FEDORA-2023-c951664334 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2023-11-23 02:44:58 UTC
FEDORA-EPEL-2023-75445c8ae4 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2023-11-23 03:07:14 UTC
FEDORA-2023-1e0e93fe68 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.