Bug 2250315

Summary: Review Request: golang-github-matrix-org-gomatrixserverlib - Go library for matrix federation
Product: [Fedora] Fedora Reporter: Kai A. Hiller <V02460>
Component: Package ReviewAssignee: Mikel Olasagasti Uranga <mikel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mikel, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: mikel: fedora-review+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-04-11 23:33:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2249874, 2250311, 2250312, 2250314    
Bug Blocks: 2250408    

Description Kai A. Hiller 2023-11-17 17:08:26 UTC
Spec URL: https://v02460.fedorapeople.org/golang-github-matrix-org-gomatrixserverlib.spec
SRPM URL: https://v02460.fedorapeople.org/golang-github-matrix-org-gomatrixserverlib-0-0.1.20231115git58af9a2.fc40.src.rpm
Description: Go library for matrix federation
Fedora Account System Username: v02460

Comment 2 Fedora Review Service 2023-11-22 01:56:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6677218
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250315-golang-github-matrix-org-gomatrixserverlib/fedora-rawhide-x86_64/06677218-golang-github-matrix-org-gomatrixserverlib/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2024-03-15 17:53:53 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7165357
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250315-golang-github-matrix-org-gomatrixserverlib/fedora-rawhide-x86_64/07165357-golang-github-matrix-org-gomatrixserverlib/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Mikel Olasagasti Uranga 2024-04-07 10:13:33 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 6 Fedora Admin user for bugzilla script actions 2024-04-11 21:12:18 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-matrix-org-gomatrixserverlib

Comment 7 Fedora Update System 2024-04-11 23:29:40 UTC
FEDORA-2024-1d832abc8f (golang-github-matrix-org-gomatrixserverlib-0-0.2.20240411gitc2391f7.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1d832abc8f

Comment 8 Fedora Update System 2024-04-11 23:33:22 UTC
FEDORA-2024-1d832abc8f (golang-github-matrix-org-gomatrixserverlib-0-0.2.20240411gitc2391f7.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.