Bug 225718
| Summary: | Merge Review: eel2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Deji Akingunola <dakingun> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alexl |
| Target Milestone: | --- | Flags: | dakingun:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-08-11 01:37:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 18:31:49 UTC
GOOD: * Package name conforms to the Fedora Naming Guidelines * Group and License tags properly in place * Locales handled correctly * All necessary BuildRequires listed. * Package builds OK in Mock. * Source matches upstream md5sum: dd06a56773af79e4292e63c6bcca9449 eel-2.18.0.1.tar.bz2 NEEDSWORK: * Source url not given in the spec * eel2-devel should not own %{_libdir}/pkgconfig, the -devel %files section should have /usr/lib/pkgconfig/eel-2.0.pc instead * rpmlint warnings: $ rpmlint eel2-2.18.0.1-3.fc7.src.rpm W: eel2 mixed-use-of-spaces-and-tabs (spaces: line 17, tab: line 16) $ rpmlint eel2-2.18.0.1-3.fc7.x86_64.rpm W: eel2 spurious-executable-perm /usr/share/doc/eel2-2.18.0.1/COPYING $ rpmlint eel2-devel-2.18.0.1-3.fc7.x86_64.rpm W: eel2-devel no-documentation (can be ignored!) Minor nit: $RPM_OPT_FLAGS already includes a '-g' option Fixed in -5 I'm sorry I almost forgot about this. All issues in comment #1 are now fixed; rpmlint is now silent on the srpm and the binaries (except for the ignorable one), and all packaged files are properly owned. APPROVED Review done. |