Bug 2257210

There are still FIXMEs in the spec file, I assume you wanted to drop the file-id executable from the package since you're interested in this as a library dependency?

(In reply to Fabio Valentini from comment #1)
> There are still FIXMEs in the spec file, I assume you wanted to drop the
> file-id executable from the package since you're interested in this as a
> library dependency?

Yes indeed. Thanks, updated.

Spec URL: https://salimma.fedorapeople.org/rust-file-id.spec
SRPM URL: https://salimma.fedorapeople.org/rust-file-id-0.2.1-1.fc38.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6888638
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257210-rust-file-id/fedora-rawhide-x86_64/06888638-rust-file-id/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Looks like the links still point at the old version?

Oh dumb, I uploaded my new specs to /specs/ now but this was originally uploaded to the old location


Spec URL: https://salimma.fedorapeople.org/specs/rust-file-id.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-file-id-0.2.1-1.fc38.src.rpm

Created attachment 2008440 [details]
The .spec file difference from Copr build 6888638 to 6888870

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6888870
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257210-rust-file-id/fedora-rawhide-x86_64/06888870-rust-file-id/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-file-id

FEDORA-2024-5eb1b4e36f has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5eb1b4e36f

FEDORA-2024-5eb1b4e36f has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-05bc475bc6 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-05bc475bc6

FEDORA-2024-bdaa3f05b4 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-bdaa3f05b4

FEDORA-2024-bdaa3f05b4 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-bdaa3f05b4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-bdaa3f05b4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-05bc475bc6 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-05bc475bc6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-05bc475bc6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-bdaa3f05b4 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-05bc475bc6 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.