Bug 2257210 - Review Request: rust-file-id - Utility for reading inode numbers (Linux, MacOS) and file IDs (Windows)
Summary: Review Request: rust-file-id - Utility for reading inode numbers (Linux, MacO...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/file-id
Whiteboard:
Depends On:
Blocks: 2257209
TreeView+ depends on / blocked
 
Reported: 2024-01-07 23:42 UTC by Michel Lind
Modified: 2024-01-23 01:21 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-14 03:12:32 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6888638 to 6888870 (1.29 KB, patch)
2024-01-12 20:40 UTC, Fedora Review Service
no flags Details | Diff

Description Michel Lind 2024-01-07 23:42:14 UTC
Spec URL: https://salimma.fedorapeople.org/rust-file-id.spec
SRPM URL: https://salimma.fedorapeople.org/rust-file-id-0.2.1-1.fc38.src.rpm

Description:
Utility for reading inode numbers (Linux, MacOS) and file IDs (Windows).

Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2024-01-08 19:09:35 UTC
There are still FIXMEs in the spec file, I assume you wanted to drop the file-id executable from the package since you're interested in this as a library dependency?

Comment 2 Michel Lind 2024-01-12 18:51:42 UTC
(In reply to Fabio Valentini from comment #1)
> There are still FIXMEs in the spec file, I assume you wanted to drop the
> file-id executable from the package since you're interested in this as a
> library dependency?

Yes indeed. Thanks, updated.

Spec URL: https://salimma.fedorapeople.org/rust-file-id.spec
SRPM URL: https://salimma.fedorapeople.org/rust-file-id-0.2.1-1.fc38.src.rpm

Comment 3 Fedora Review Service 2024-01-12 18:59:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6888638
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257210-rust-file-id/fedora-rawhide-x86_64/06888638-rust-file-id/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2024-01-12 20:31:53 UTC
Looks like the links still point at the old version?

Comment 5 Michel Lind 2024-01-12 20:33:51 UTC
Oh dumb, I uploaded my new specs to /specs/ now but this was originally uploaded to the old location


Spec URL: https://salimma.fedorapeople.org/specs/rust-file-id.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-file-id-0.2.1-1.fc38.src.rpm

Comment 6 Fedora Review Service 2024-01-12 20:40:46 UTC
Created attachment 2008440 [details]
The .spec file difference from Copr build 6888638 to 6888870

Comment 7 Fedora Review Service 2024-01-12 20:40:49 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6888870
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257210-rust-file-id/fedora-rawhide-x86_64/06888870-rust-file-id/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fabio Valentini 2024-01-12 20:47:48 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 9 Fedora Admin user for bugzilla script actions 2024-01-14 02:55:18 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-file-id

Comment 10 Fedora Update System 2024-01-14 03:11:39 UTC
FEDORA-2024-5eb1b4e36f has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5eb1b4e36f

Comment 11 Fedora Update System 2024-01-14 03:12:32 UTC
FEDORA-2024-5eb1b4e36f has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-01-14 03:40:21 UTC
FEDORA-2024-05bc475bc6 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-05bc475bc6

Comment 13 Fedora Update System 2024-01-14 03:40:21 UTC
FEDORA-2024-bdaa3f05b4 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-bdaa3f05b4

Comment 14 Fedora Update System 2024-01-15 01:04:26 UTC
FEDORA-2024-bdaa3f05b4 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-bdaa3f05b4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-bdaa3f05b4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-01-15 02:05:29 UTC
FEDORA-2024-05bc475bc6 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-05bc475bc6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-05bc475bc6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2024-01-23 00:57:33 UTC
FEDORA-2024-bdaa3f05b4 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2024-01-23 01:21:40 UTC
FEDORA-2024-05bc475bc6 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.