Bug 2257921

Summary:	Review Request: python-medimages4tests - Generates dummy medical image for image handling tests
Product:	[Fedora] Fedora	Reporter:	Sandro <gui1ty>
Component:	Package Review	Assignee:	Ben Beasley <code>
Status:	CLOSED DEFERRED	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	code, package-review
Target Milestone:	---	Flags:	code: fedora-review-
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-01-16 13:43:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2257916
Bug Blocks:	182235, 1276941, 2257923

Description Sandro 2024-01-11 14:40:39 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/gui1ty/xnat4tests/fedora-rawhide-x86_64/06880374-python-medimages4tests/python-medimages4tests.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/gui1ty/xnat4tests/fedora-rawhide-x86_64/06880374-python-medimages4tests/python-medimages4tests-0.3.3-3.fc40.src.rpm

Description: 
Generate dummy medical images, with junk image data but realistic
headers, to test imaging handling pipelines.

Fedora Account System Username: gui1ty

Copr build: https://copr.fedorainfracloud.org/coprs/gui1ty/xnat4tests/build/6880374/

Comment 1 Sandro 2024-01-11 14:41:39 UTC

Package depends on `python-sgqlc` (see bug 2257916). For building / testing locally run `dnf copr enable gui1ty/xnat4tests` in order to get the missing dependencies.

Comment 2 Fedora Review Service 2024-01-11 14:43:25 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6885522
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257921-python-medimages4tests/fedora-rawhide-x86_64/06885522-python-medimages4tests/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Sandro 2024-01-11 14:49:29 UTC

Sigh. CopyPasta gone wrong.

Package depends on `openneuro-py` (see bug 2257916). For building / testing locally run `dnf copr enable gui1ty/xnat4tests` in order to get the missing dependencies.

Comment 4 Ben Beasley 2024-01-16 13:43:13 UTC

As a Python library (and furthermore, as an image *generator* rather than a collection of images that happens to be installed as a Python library), this package clearly contains *code* under the CC0-1.0 license, which is not-allowed for code in Fedora.

(The trove classifier "License :: OSI Approved :: Apache Software License" conflicts with the LICENSE file, which is certainly CC0-1.0.)

I think you will need to ask upstream to consider relicensing, or give up on running the tests that require this.

Comment 5 Sandro 2024-01-16 15:26:02 UTC

(In reply to Ben Beasley from comment #4)
> (The trove classifier "License :: OSI Approved :: Apache Software License"
> conflicts with the LICENSE file, which is certainly CC0-1.0.)
> 
> I think you will need to ask upstream to consider relicensing, or give up on
> running the tests that require this.

My bad. I remember having a hunch when I filled in the license in the spec file. But I failed to look into this further.

I'll set this to DEFERRED for now, since I plan on asking upstream to consider relicensing under one of the allowed licenses.