Bug 2257921 - Review Request: python-medimages4tests - Generates dummy medical image for image handling tests
Summary: Review Request: python-medimages4tests - Generates dummy medical image for im...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/Australian-Imaging...
Whiteboard:
Depends On: 2257916
Blocks: fedora-neuro, NeuroFedora 2257923
TreeView+ depends on / blocked
 
Reported: 2024-01-11 14:40 UTC by Sandro
Modified: 2025-04-18 16:57 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-16 13:43:13 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Comment 1 Sandro 2024-01-11 14:41:39 UTC
Package depends on `python-sgqlc` (see bug 2257916). For building / testing locally run `dnf copr enable gui1ty/xnat4tests` in order to get the missing dependencies.

Comment 2 Fedora Review Service 2024-01-11 14:43:25 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6885522
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257921-python-medimages4tests/fedora-rawhide-x86_64/06885522-python-medimages4tests/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Sandro 2024-01-11 14:49:29 UTC
Sigh. CopyPasta gone wrong.

Package depends on `openneuro-py` (see bug 2257916). For building / testing locally run `dnf copr enable gui1ty/xnat4tests` in order to get the missing dependencies.

Comment 4 Ben Beasley 2024-01-16 13:43:13 UTC
As a Python library (and furthermore, as an image *generator* rather than a collection of images that happens to be installed as a Python library), this package clearly contains *code* under the CC0-1.0 license, which is not-allowed for code in Fedora.

(The trove classifier "License :: OSI Approved :: Apache Software License" conflicts with the LICENSE file, which is certainly CC0-1.0.)

I think you will need to ask upstream to consider relicensing, or give up on running the tests that require this.

Comment 5 Sandro 2024-01-16 15:26:02 UTC
(In reply to Ben Beasley from comment #4)
> (The trove classifier "License :: OSI Approved :: Apache Software License"
> conflicts with the LICENSE file, which is certainly CC0-1.0.)
> 
> I think you will need to ask upstream to consider relicensing, or give up on
> running the tests that require this.

My bad. I remember having a hunch when I filled in the license in the spec file. But I failed to look into this further.

I'll set this to DEFERRED for now, since I plan on asking upstream to consider relicensing under one of the allowed licenses.

Comment 6 Sandro 2025-04-18 16:51:15 UTC
Upstream has relicensed the package under Apache-2.0. I'm reopening the review request.

Spec URL: https://fedorapeople.org/~gui1ty/review/python-medimages4tests.spec
SRPM URL: https://fedorapeople.org/~gui1ty/review/python-medimages4tests-0.5.7-1.fc43.src.rpm

Comment 7 Fedora Review Service 2025-04-18 16:57:46 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8920209
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257921-python-medimages4tests/fedora-rawhide-x86_64/08920209-python-medimages4tests/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.