Bug 2263742

Summary:	Review Request: python-opentelemetry-resource-detector-azure - OpenTelemetry Resource detectors for Azure
Product:	[Fedora] Fedora	Reporter:	Ben Beasley <code>
Component:	Package Review	Assignee:	Major Hayden 🤠 <mhayden>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mhayden, package-review
Target Milestone:	---	Flags:	mhayden: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-02-21 20:41:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ben Beasley 2024-02-11 14:56:30 UTC

Spec URL: https://music.fedorapeople.org/python-opentelemetry-resource-detector-azure.spec
SRPM URL: https://music.fedorapeople.org/python-opentelemetry-resource-detector-azure-0.1.3-1.fc39.src.rpm

Description:
This library contains OpenTelemetry Resource Detectors for the following Azure
resources:

  • Azure App Service
  • Azure Virtual Machines

Fedora Account System Username: music

This review doesn’t exactly fall under https://docs.fedoraproject.org/en-US/package-maintainers/Package_Renaming_Process/ or even https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages, but they are somewhat relevant.

The binary package produced by this new package, python3-opentelemetry-resource-detector-azure, is currently built as part of https://src.fedoraproject.org/rpms/python-opentelemetry-contrib. The goal of packaging it separately is to split out parts of https://github.com/open-telemetry/opentelemetry-python-contrib that carry separate version numbers, which complicates the python-opentelemetry-contrib package and is particularly a headache for managing the release number in that package; currently, the release needs to increment monotonically forever unless all versions change at once.

The python3-opentelemetry-resource-detector-azure subpackage of python-opentelemetry-contrib will be dropped at the same time this package is imported. It’s not necessary to fiddle with Release as in bug 2263732 and bug 2263734 in order to provide a proper upgrade path, since the version packaged here (the latest version on PyPI) is newer than the version included with the last opentelemetry-contrib-python omnibus release tag.

Comment 1 Fedora Review Service 2024-02-11 16:16:14 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7007685
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263742-python-opentelemetry-resource-detector-azure/fedora-rawhide-x86_64/07007685-python-opentelemetry-resource-detector-azure/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Major Hayden 🤠 2024-02-20 14:28:46 UTC

[fedora-review-service-build]

Comment 3 Fedora Review Service 2024-02-20 14:39:09 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7039208
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263742-python-opentelemetry-resource-detector-azure/fedora-rawhide-x86_64/07039208-python-opentelemetry-resource-detector-azure/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Major Hayden 🤠 2024-02-20 15:31:36 UTC

The fedora-review tool seems broken in rawhide/f40 still, but this package looks fine. ✅

It follows the older pyproject macros, but follows them well. Description/summary looks good and tests do run during the build. Docs + License are also present.

Comment 5 Ben Beasley 2024-02-21 19:28:53 UTC

Thanks for the review! I’m starting to import these packages.

(In reply to Major Hayden 🤠 from comment #4)
> The fedora-review tool seems broken in rawhide/f40 still, but this package
> looks fine. ✅

Try fedora-review -b <###> --mock-options=--dnf; that’s been working for me. I don’t know how long I am supposed to keep having to do fedpkg mockbuild -- --dnf in F40 and later…

> It follows the older pyproject macros, but follows them well.
> Description/summary looks good and tests do run during the build. Docs +
> License are also present.

Did you actually spot something outdated in this spec, or was that comment mixed in from another package review?

Comment 6 Fedora Admin user for bugzilla script actions 2024-02-21 19:31:03 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-opentelemetry-resource-detector-azure

Comment 7 Ben Beasley 2024-02-21 19:31:16 UTC

https://release-monitoring.org/project/371544/

Comment 8 Fedora Update System 2024-02-21 20:40:45 UTC

FEDORA-2024-06da2a8704 (python-opentelemetry-contrib-1.22.0-52.fc41, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc41, and 2 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-06da2a8704

Comment 9 Fedora Update System 2024-02-21 20:41:59 UTC

FEDORA-2024-06da2a8704 (python-opentelemetry-contrib-1.22.0-52.fc41, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc41, and 2 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2024-02-22 12:22:48 UTC

FEDORA-2024-e1ffd5d470 (python-opentelemetry-contrib-1.22.0-52.fc40, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc40, and 2 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e1ffd5d470

Comment 11 Fedora Update System 2024-02-22 18:46:39 UTC

FEDORA-2024-e1ffd5d470 (python-opentelemetry-contrib-1.22.0-52.fc40, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc40, and 2 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.