Spec URL: https://music.fedorapeople.org/python-opentelemetry-resource-detector-azure.spec SRPM URL: https://music.fedorapeople.org/python-opentelemetry-resource-detector-azure-0.1.3-1.fc39.src.rpm Description: This library contains OpenTelemetry Resource Detectors for the following Azure resources: • Azure App Service • Azure Virtual Machines Fedora Account System Username: music This review doesn’t exactly fall under https://docs.fedoraproject.org/en-US/package-maintainers/Package_Renaming_Process/ or even https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages, but they are somewhat relevant. The binary package produced by this new package, python3-opentelemetry-resource-detector-azure, is currently built as part of https://src.fedoraproject.org/rpms/python-opentelemetry-contrib. The goal of packaging it separately is to split out parts of https://github.com/open-telemetry/opentelemetry-python-contrib that carry separate version numbers, which complicates the python-opentelemetry-contrib package and is particularly a headache for managing the release number in that package; currently, the release needs to increment monotonically forever unless all versions change at once. The python3-opentelemetry-resource-detector-azure subpackage of python-opentelemetry-contrib will be dropped at the same time this package is imported. It’s not necessary to fiddle with Release as in bug 2263732 and bug 2263734 in order to provide a proper upgrade path, since the version packaged here (the latest version on PyPI) is newer than the version included with the last opentelemetry-contrib-python omnibus release tag.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7007685 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263742-python-opentelemetry-resource-detector-azure/fedora-rawhide-x86_64/07007685-python-opentelemetry-resource-detector-azure/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/7039208 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263742-python-opentelemetry-resource-detector-azure/fedora-rawhide-x86_64/07039208-python-opentelemetry-resource-detector-azure/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The fedora-review tool seems broken in rawhide/f40 still, but this package looks fine. ✅ It follows the older pyproject macros, but follows them well. Description/summary looks good and tests do run during the build. Docs + License are also present.
Thanks for the review! I’m starting to import these packages. (In reply to Major Hayden 🤠 from comment #4) > The fedora-review tool seems broken in rawhide/f40 still, but this package > looks fine. ✅ Try fedora-review -b <###> --mock-options=--dnf; that’s been working for me. I don’t know how long I am supposed to keep having to do fedpkg mockbuild -- --dnf in F40 and later… > It follows the older pyproject macros, but follows them well. > Description/summary looks good and tests do run during the build. Docs + > License are also present. Did you actually spot something outdated in this spec, or was that comment mixed in from another package review?
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-opentelemetry-resource-detector-azure
https://release-monitoring.org/project/371544/
FEDORA-2024-06da2a8704 (python-opentelemetry-contrib-1.22.0-52.fc41, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc41, and 2 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-06da2a8704
FEDORA-2024-06da2a8704 (python-opentelemetry-contrib-1.22.0-52.fc41, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc41, and 2 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-e1ffd5d470 (python-opentelemetry-contrib-1.22.0-52.fc40, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc40, and 2 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e1ffd5d470
FEDORA-2024-e1ffd5d470 (python-opentelemetry-contrib-1.22.0-52.fc40, python-opentelemetry-propagator-aws-xray-1.0.1-52.fc40, and 2 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.